This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Add basic unit tests policy #3411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmacdo
reviewed
Apr 5, 2018
docs/contributing/unit_tests.rst
Outdated
| Unit Tests | ||
| ========== | ||
|
|
||
| All new code is highly encouraged to have basic unit tests that demonstrate its functionality. A |
|
Thanks @asmacdo, I fixed it |
asmacdo
approved these changes
Apr 5, 2018
daviddavis
approved these changes
Apr 5, 2018
dralley
approved these changes
Apr 6, 2018
|
Btw, it looks like you have a commit you need to squash. |
This policy is a starting point based feedback via pulp-dev. The language adopted was shared via pulp-dev for comment.
bmbouter
force-pushed
the
add-unit-test-policy-to-docs
branch
from
02f1f4d
to
8cc7752
Compare
|
Why yes I did. Thank you. |
|
Looks good to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This policy is a starting point based feedback via pulp-dev. The
language adopted was shared via pulp-dev for comment.