Require PRs from pulp_file and pulp-smash #3435
Conversation
dkliban
force-pushed
the
require-pr
branch
8 times, most recently
from
3382953
to
0d11011
Compare
| @@ -8,26 +8,34 @@ pushd common/ && pip install -e . && popd | |||
| pushd pulpcore/ && pip install -e . && popd | |||
| pushd plugin/ && pip install -e . && popd | |||
|
|
|||
| export COMMIT_MSG=$(git log --format=%B -n 1 HEAD) | |||
| export COMMIT_MSG=$(git show HEAD^2 -s) | |||
There was a problem hiding this comment.
FYI, there's a variable for this I believe. Something like $TRAVIS_COMMIT_MESSAGE.
There was a problem hiding this comment.
There is, but it's for the merge commit of the PR into the branch it's going to. So it only says "Merge of blah into bleh". I have to find the parent commit of that.
There was a problem hiding this comment.
git log has an option for ignoring merge commits --no-merges. You could try that.
dkliban
changed the title
| cd pulp-smash | ||
| git fetch origin +refs/pull/$PULP_SMASH_PR_NUMBER/merge | ||
| git checkout $PULP_SMASH_SHA | ||
| pip install -e . |
There was a problem hiding this comment.
Wondering if we should DRY this up with a bash function?
There was a problem hiding this comment.
let's DRY up in a separate PR. please?
| .. _file: https://github.com/PulpQE/pulp-smash/tree/master/pulp_smash/tests/pulp3/file | ||
| .. _pulp-smash: https://github.com/PulpQE/pulp-smash/ | ||
|
|
||
| Continuous Integration |
There was a problem hiding this comment.
I think these docs are great, thanks!
dkliban
force-pushed
the
require-pr
branch
6 times, most recently
from
2c6dc12
to
52c1589
Compare
The PRs listed in this commit message are just for demonstrating that Travis will checkout those PRs when testing the PR that contains this commit. closes pulp#3530 https://pulp.plan.io/issues/3530 Required PR: pulp/pulp_file#65 Required PR: pulp/pulp-smash#770
|
Should the commit be updated to remove the lines |
|
The commit message says that those lines are in the commit message for testing purposes only. Should I remove them and test that the PR still passes tests? |
|
No, I missed that. Let's merge. |
Require PRs from pulp_file and pulp-smash
The PRs listed in this commit message are just for demonstrating that
Travis will checkout those PRs when testing the PR that contains this
commit.
closes #3530
https://pulp.plan.io/issues/3530
Required PR: pulp/pulp_file#65
Required PR: pulp/pulp-smash#770