introducing integrity

[dparalen]

To test:

sudo -u apache pulp-integrity --check size --check broken_rpm_symlinks | jq '[.report[].repository] | unique'

TODO:

• review/refactor the validator module to rely more on mixins than inheritance

[pep8speaks]

Hello @dparalen! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on June 08, 2018 at 08:34 Hours UTC

[pulpbot]

Can one of the admins verify this patch?

[asmacdo]

Is there an issue associated with this? Specifically, I'd like to see a summary of the motivation for this change.

[dparalen]

@asmacdo https://pulp.plan.io/issues/2619 I forgotten a link in the commit message (just #ID there), will submit with next update

[dkliban]

While running this on an older Pulp I ran into a problem where this tools was relying on a method in pulp_rpm that did not exist. I left a comment in the code to show where.

This tool should probably rely only on the model schema. Any other code could be significantly different from version to version of Pulp. Even though it is not DRY, you should probably just copy the methods you need from pulp_rpm into this tool. This way we'll be able to run this tool against older versions of Pulp.

Since the symlink validator is very much related to the yum_distributor, I recommend putting this tool in the pulp_rpm repository.

[dkliban]

This method is not available in older versions of pulp_rpm.

[dkliban]

It looks like this validator is very specific to pulp_rpm.

[dparalen]

@dkliban, thanks for the review!
moving the rpm tools to the pulp_rpm repo; see pulp/pulp_rpm#1104