This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Have get_resource() use pk and only pk if pk is provided #3468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another alternative fix would be to move this logic outside of the else: https://github.com/pulp/pulp/pull/3468/files#diff-ae7f375b1b9eaee42aecdf250679cd6eL137 |
We should ignore other kwargs since pk should uniquely identify the resource. The problem we were experiencing in pulp_ansible is that we had a pk and a role_pk. The conversion from role_pk to role_id only happens inside the else block and so we're getting a FieldError because role_pk doesn't exist on the model. Instead, I think we should just use the pk kwarg and ignore the rest.
Codecov Report
@@ Coverage Diff @@
## 3.0-dev #3468 +/- ##
========================================
Coverage 57.03% 57.03%
========================================
Files 59 59
Lines 2509 2509
========================================
Hits 1431 1431
Misses 1078 1078
Continue to review full report at Codecov.
|
dkliban
approved these changes
Apr 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should ignore other kwargs since pk should uniquely identify the
resource. The problem we were experiencing in pulp_ansible is that we
had a pk and a role_pk. The conversion from role_pk to role_id only
happens inside the else block and so we're getting a FieldError because
role_pk doesn't exist on the model. Instead, I think we should just use
the pk kwarg and ignore the rest.