Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.

Using querysets for add/remove_content methods #3548

Merged
merged 1 commit into from Jul 10, 2018
Merged

Using querysets for add/remove_content methods #3548

merged 1 commit into from Jul 10, 2018

Conversation

daviddavis
Copy link
Contributor

@codecov
Copy link

codecov bot commented Jul 9, 2018

Codecov Report

Merging #3548 into master will increase coverage by 0.14%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3548      +/-   ##
==========================================
+ Coverage   57.44%   57.58%   +0.14%     
==========================================
  Files          59       59              
  Lines        2465     2459       -6     
==========================================
  Hits         1416     1416              
+ Misses       1049     1043       -6
Impacted Files Coverage Δ
pulpcore/pulpcore/app/models/repository.py 55.07% <0%> (+0.78%) ⬆️
pulpcore/pulpcore/app/tasks/repository.py 37.03% <0%> (+4.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 055c3da...1787314. Read the comment docs.

Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks correct to me. I plan to rebase my code onto it for further testing post-merge. If you want formal pre-merge testing let me know, but I think Travis working is enough for me.

@dralley
Copy link
Contributor

dralley commented Jul 10, 2018

@bmbouter, @daviddavis I know this is something we don't really have bandwidth for, but it would be great to have a set of performance tracking tests to see the impact of changes like this, and future ones. I'm not sure how difficult that would be to do.

@bmbouter
Copy link
Member

@dralley I'm a +1 on tracking that how our code changes affect the code performance over time. We have a performance tracking plan written up with some ideas. Overall I think we know what to track and how to do it, so we're blocked on time currently.

@daviddavis daviddavis merged commit 9bfc50d into pulp:master Jul 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants