Update Pulp Smash configuration file #3553
Conversation
| @@ -1,20 +1,18 @@ | |||
| { | |||
| "pulp": { | |||
| "auth": ["admin", "admin"], | |||
| "selinux enabled": false, | |||
There was a problem hiding this comment.
The ability to specify that SELinux is not supported was already present.
| "version": "3" | ||
| }, | ||
| "systems": [ | ||
| "hosts": [ |
There was a problem hiding this comment.
The "systems" key was renamed to "hosts" some time ago. The continuing validity of the "systems" key is a backwards compatibility measure.
Pulp Smash recently updated its configuration machinery to properly handle both Pulp 2 and Pulp 3. As a result, the definition of a valid configuration file has changed. Update the Pulp Smash configuration file used for testing accordingly. See: pulp/pulp-smash#1101
Codecov Report
@@ Coverage Diff @@
## master #3553 +/- ##
=======================================
Coverage 58.09% 58.09%
=======================================
Files 59 59
Lines 2453 2453
=======================================
Hits 1425 1425
Misses 1028 1028Continue to review full report at Codecov.
|
| "api": {"port": 8000, "scheme": "http"}, | ||
| "mongod": {}, | ||
| "pulp cli": {}, | ||
| "api": {"port": 8000, "scheme": "http", "service": "nginx"}, |
There was a problem hiding this comment.
Technically speaking, nginx isn't being used for the server in this context (just the django dev server), but if it doesn't matter this is fine.
There was a problem hiding this comment.
It doesn't matter at this time. It'll matter when the Pulp 3 tests start restarting the web server.
Pulp Smash recently updated its configuration machinery to properly
handle both Pulp 2 and Pulp 3. As a result, the definition of a valid
configuration file has changed. Update the Pulp Smash configuration file
used for testing accordingly.
See: pulp/pulp-smash#1101