This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Remove the GroupDownloader #3606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmbouter
force-pushed
the
remove-group-downloader
branch
from
39b19b0
to
8f135c5
Compare
The GroupDownloader is not needed. See the ticket description for more info. Also the 'attach_url_to_exception' was only here to serve the GroupDownloader so that is also being removed. https://pulp.plan.io/issues/3923 closes pulp#3923
bmbouter
force-pushed
the
remove-group-downloader
branch
from
8f135c5
to
d9eb035
Compare
Codecov Report
@@ Coverage Diff @@
## master #3606 +/- ##
======================================
Coverage 57.7% 57.7%
======================================
Files 60 60
Lines 2523 2523
======================================
Hits 1456 1456
Misses 1067 1067Continue to review full report at Codecov.
|
dkliban
approved these changes
Aug 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GroupDownloader is not needed. See the ticket description for more
info.
Also the 'attach_url_to_exception' was only here to serve the
GroupDownloader so that is also being removed.
https://pulp.plan.io/issues/3923
closes #3923