Problem: pulpcore-common is not used outside of pulpcore

[dkliban]

Solution: move constants into pulpcore.constants and remove pulpcore-common package

closes: #3652
https://pulp.plan.io/issues/3652

[pep8speaks]

Hello @dkliban! Thanks for submitting the PR.

• There are no PEP8 issues in the file pulpcore/pulpcore/app/models/progress.py !

• There are no PEP8 issues in the file pulpcore/pulpcore/app/models/task.py !

• There are no PEP8 issues in the file pulpcore/pulpcore/app/urls.py !

• There are no PEP8 issues in the file pulpcore/pulpcore/app/viewsets/task.py !

• There are no PEP8 issues in the file pulpcore/pulpcore/tasking/services/worker_watcher.py !

• There are no PEP8 issues in the file pulpcore/pulpcore/tasking/tasks.py !

• There are no PEP8 issues in the file pulpcore/pulpcore/tasking/util.py !

• There are no PEP8 issues in the file pulpcore/setup.py !

• There are no PEP8 issues in the file pulpcore/tests/unit/viewsets/test_base.py !

[codecov]

Codecov Report

Merging #3662 into master will increase coverage by 0.13%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master    #3662      +/-   ##
==========================================
+ Coverage    55.8%   55.93%   +0.13%     
==========================================
  Files          61       62       +1     
  Lines        2695     2703       +8     
==========================================
+ Hits         1504     1512       +8     
  Misses       1191     1191

Impacted Files	Coverage Δ
pulpcore/pulpcore/constants.py	100% <ø> (ø)
...lpcore/pulpcore/tasking/services/worker_watcher.py	0% <0%> (ø)	⬆️
pulpcore/pulpcore/app/models/progress.py	51.72% <100%> (ø)	⬆️
pulpcore/pulpcore/app/urls.py	91.93% <100%> (ø)	⬆️
pulpcore/pulpcore/app/viewsets/task.py	76.56% <100%> (ø)	⬆️
pulpcore/pulpcore/tasking/tasks.py	19.27% <100%> (ø)	⬆️
pulpcore/pulpcore/tasking/util.py	32.65% <100%> (ø)	⬆️
pulpcore/pulpcore/app/models/task.py	57.4% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a18058a...80a17ae. Read the comment docs.

[daviddavis]

Should this file be renamed to constants.rst?

[CodeHeeler]

+1 renaming to constants.rst for consistency

[daviddavis]

One small question. LGTM though.

[dkliban]

I renamed the file.