Add Pulp 3 container image built from PyPi #3740
Conversation
|
Hello @ehelms! Thanks for updating the PR.
Comment last updated on February 06, 2019 at 01:11 Hours UTC |
ehelms
force-pushed
the
add-dockerfile
branch
3 times, most recently
from
8593a46
to
c8d36ab
Compare
ehelms
force-pushed
the
add-dockerfile
branch
2 times, most recently
from
60e0fb7
to
256a9bd
Compare
|
@bmbouter Sounded like from mailing list your request would be to split this into an image per service? I'm good with that direction, wanting clarity before I do work towards it. |
|
@ehelms If you are able to split it into one image per service, I think that would be great! |
ehelms
force-pushed
the
add-dockerfile
branch
from
256a9bd
to
44260de
Compare
ehelms
force-pushed
the
add-dockerfile
branch
from
44260de
to
75f4eda
Compare
|
@bmbouter This is ready for another round of review with split, individual images based on a pulp-core image. |
|
|
||
| RUN mkdir -p /etc/pulp | ||
|
|
||
| RUN scl enable rh-python36 'pip install gunicorn' |
There was a problem hiding this comment.
should these three be compacted to one RUN to save a few layers?
| COPY container-assets/settings.py /etc/pulp/settings.py | ||
| RUN echo "SECRET_KEY = '`cat /dev/urandom | tr -dc 'a-z0-9!@#$%^&*(\-_=+)' | head -c 50`'" >> /etc/pulp/settings.py | ||
|
|
||
| RUN scl enable rh-python36 "pulp-manager makemigrations pulp_app" |
There was a problem hiding this comment.
should these three be compacted to one RUN to save a few layers?
| vars_files: | ||
| - vars/defaults.yaml | ||
| tasks: | ||
| - name: 'Check for podman' |
There was a problem hiding this comment.
given both playbooks have "check for podman" and "set_fact" steps, should this be moved to a "select_container_cli" role?
|
@ehelms status? |
|
This repository has moved to https://github.com/pulp/pulpcore. As such this PR needs to close and be reopened over there. Could you please:
If you're need any help doing this please visit in #pulp-dev on IRC for help. Thank you and sorry for the disruption. |
In our discussions, the idea was for this to live in the Pulp main repository and to at least start off as an all-in-one image. There is related work to add running via the containers to the Ansible installer (pulp/pulp_installer#45). There are still some gaps to address here in terms of process:
I'm sure there are some other elements to address but this gets us started.
This was inspired by my POC project carafe.