Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.

Align default settings with new content app #3802

Merged
merged 1 commit into from Dec 17, 2018

Conversation

mdellweg
Copy link
Member

@pep8speaks
Copy link

Hello @mdellweg! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #3802 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3802   +/-   ##
=======================================
  Coverage   53.39%   53.39%           
=======================================
  Files          64       64           
  Lines        2742     2742           
=======================================
  Hits         1464     1464           
  Misses       1278     1278

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0644568...79492ca. Read the comment docs.

Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I forgot we were still carrying this file.

@bmbouter bmbouter merged commit 415679c into pulp:master Dec 17, 2018
@mdellweg
Copy link
Member Author

You could have asked me to delete it. ;)

@mdellweg mdellweg deleted the content_app_settings branch December 17, 2018 16:14
@mdellweg
Copy link
Member Author

@bmbouter You might also need to re'MODIFIED' the plan.io ticket.

@bmbouter
Copy link
Member

@mdellweg I moved the ticket back to MODIFIED. I do think that we need to delete this file every since we switched to dynaconf. I'll email pulp-dev because I want to highlight the reasoning there.

@bmbouter
Copy link
Member

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants