Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.

Updating Developer Setup Guide to use Pulplift #3824

Merged
merged 1 commit into from Jan 15, 2019

Conversation

CodeHeeler
Copy link

@CodeHeeler CodeHeeler commented Jan 9, 2019

Instructs the developer to setup their environment with Pulplift

re #4234
https://pulp.plan.io/issues/4234

@codecov
Copy link

codecov bot commented Jan 9, 2019

Codecov Report

Merging #3824 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3824   +/-   ##
=======================================
  Coverage   55.61%   55.61%           
=======================================
  Files          66       66           
  Lines        2807     2807           
=======================================
  Hits         1561     1561           
  Misses       1246     1246

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e2b677...cc9fa8f. Read the comment docs.

repository <https://github.com/pulp/devel/>`_ and on the `wiki
<https://pulp.plan.io/projects/pulp/wiki/Developer_Install_Options>`_.
Navigate into the pulplift directory. Run the setup.sh script which will clone the 'forklift' and
'ansible-pulp3' repos::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to ansible-pulp3 repo


The parent directory of 'pulplift' is going to be mounted into the vagrant box at
/home/vagrant/devel. Any plugins that need to be installed should be added to the
forklift/ansible-pulp3/source-install.yml playbook. The paths to the source of the plugins should
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/forklift/pulplift/

Copy link
Member

@dkliban dkliban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small changes. Otherwise it's good.

Instructs the developer to setup their environment with Pulplift

re #4234
https://pulp.plan.io/issues/4234
To ease developer setup, we have Ansible roles, playbooks and a Vagrantfile in our `pulp/devel
<https://github.com/pulp/devel/>`_ repository. Use the :ref:`quickstart` to dive in with an example
configuration.
To ease developer setup, we have `Pulplift <https://github.com/ehelms/pulplift>`_ which is based on
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make any sense to move this into the Pulp or and update this link to that pre-merge?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the link after the repo is transferred.

@dkliban dkliban merged commit 331e587 into pulp:master Jan 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants