Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As an user, I can view information for a role in Pulp #1

Merged
merged 1 commit into from Mar 1, 2018

Conversation

@daviddavis
Copy link
Contributor

commented Feb 27, 2018

log = getLogger(__name__)


class AnsibleRoleContent(Content):

This comment has been minimized.

Copy link
@daviddavis

daviddavis Mar 1, 2018

Author Contributor

Should we call this AnsibleRole?

This comment has been minimized.

Copy link
@bmbouter

bmbouter Mar 1, 2018

Member

Yes I think so.

@daviddavis daviddavis force-pushed the daviddavis:role-information branch 3 times, most recently from 7bbb015 to 859c2e1 Mar 1, 2018
)


class AnsiblePublisher(Publisher):

This comment has been minimized.

Copy link
@bmbouter

bmbouter Mar 1, 2018

Member

Will this publisher only handle AnsibleRole stuff or will it handle other types in the future as well like TheNextAnsibleThing? If it's always-and-forever AnsibleRole, should this be called AnsibleRolePublisher?

This comment has been minimized.

Copy link
@daviddavis

daviddavis Mar 1, 2018

Author Contributor

My assumption (at least for now) was that we'd want to publish all Ansible content in a repo together (not just roles).

This comment has been minimized.

Copy link
@bmbouter

bmbouter Mar 1, 2018

Member

Great then this is the right name. Ack.


class AnsibleRole(Content):
"""
A content type respresenting an ansible role

This comment has been minimized.

Copy link
@bmbouter

bmbouter Mar 1, 2018

Member

s/ansible role/Ansible Role/

@bmbouter

This comment has been minimized.

Copy link
Member

commented Mar 1, 2018

I was able to install the plugin and makemigrations for it! It did make migrations correctly for the 3 models.

@daviddavis daviddavis force-pushed the daviddavis:role-information branch from 859c2e1 to 897e033 Mar 1, 2018
Copy link
Member

left a comment

Thanks @daviddavis this looks right and ready for merging!

@daviddavis daviddavis merged commit 5f36517 into pulp:master Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.