Adds pulp-smash test for ansible remote

[dkliban]

No description provided.

[daviddavis]

A couple small comments. Looks good!

[daviddavis]

Mind breaking up these two lines onto multiple?

pushd pulp
git fetch origin +refs/pull/$PULP_PR_NUMBER/merge
git checkout $PULP_SHA
popd

[daviddavis]

Same here.

[dralley]

Presuming that you guys want to have unit tests running out of tests directory also, I think you need to move the directory inside of the pulp_ansible folder. Since you don't have any unit tests currently, it's not a problem, but it might be eventually.

Unit tests have to be run by the larger Django project (pulpcore), since that is what possesses the information about the databases. Django therefore needs to be able to discover the the tests, which I don't think it can do unless they're nested inside the package (e.g. pulp_ansible/tests) as opposed to adjacent to it.

I've been trying to figure out a way around that with pulp_python, but haven't been able to thus far. If you do find a way, let me know.

It's frustratingly inconsistent because, it does work that way for pulpcore, because manage.py can see the tests folder even though it isn't nested. But that doesn't work here.

[asmacdo]

download_policy and sync_mode are no longer a part of the base remote.

[omaciel]

@daviddavis for the time being, my only suggestion is that you use the following layout for where your tests should reside:

tests/functional/test_crud_remotes.py

In other words, rename the pulp_smash folder to functional. This has the added bonus of allowing you to create a future unit folder for unit tests

[dkliban]

I'll update this PR based on the feedback.

[dralley]

Regarding my previous comment, here is the solution I came up with.

Nest tests inside your package, next to apps.

In order to run unit tests, point the test runner directly at the unit test directory so that it doesn't detect the smash tests.

In order to run the smash tests, point that test runner at the functional test directory so that it doesn't detect the unit tests.

https://github.com/pulp/pulp_python/pull/151/files#diff-cd31ca8078680e1895d11f56d1fe38c2

Although like I mentioned earlier won't really matter until you get some unit tests.