Renaming base fields #218
Renaming base fields #218
Conversation
|
Hello @fabricio-aguiar! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-10-09 18:48:06 UTC |
| model_name='tag', | ||
| old_name='_id', | ||
| new_name='pulp_id', | ||
| ), |
There was a problem hiding this comment.
Why did you update this migration instead of adding this to 0013_pulp_fields.py?
There was a problem hiding this comment.
| @@ -18,7 +18,7 @@ | |||
| coalesce(string_agg("ansible_tag"."name", ' '), '') | |||
| ), 'B') | |||
| FROM | |||
| "ansible_tag" INNER JOIN "ansible_collectionversion_tags" ON ("ansible_tag"."_id" = "ansible_collectionversion_tags"."tag_id") | |||
| "ansible_tag" INNER JOIN "ansible_collectionversion_tags" ON ("ansible_tag"."pulp_id" = "ansible_collectionversion_tags"."tag_id") | |||
There was a problem hiding this comment.
@daviddavis I didn't know how to solve it without changing this migration
There was a problem hiding this comment.
I think we probably have to drop the vector, rename the field, and then recreate the vector. cc @bmbouter
There was a problem hiding this comment.
Given this is still pre-GA, and the complexity of having to "fix" the migration with hand-generated code in a new migration I'm ok with modifying this migration in-place.
There was a problem hiding this comment.
Either squashing or updating the migration is cool with me.
CHANGES/5457.feature
Outdated
| @@ -0,0 +1 @@ | |||
| Change `_id`, `_created`, `_last_updated`, `_href` to `pulp_id`, `pulp_created`, `pulp_last_updated`, `pulp_href` | |||
_id to pulp_id _created to pulp_created _last_updated to pulp_last_updated _href to pulp_href ref #5457 https://pulp.plan.io/issues/5457
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href
ref #5457
https://pulp.plan.io/issues/5457
Required PR: pulp/pulpcore#317
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220