Add modify_ansible_repo_content permission. #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue. |
newswangerd
force-pushed
the
add-repo-perms
branch
3 times, most recently
from
fd52b0f
to
f7b503f
Compare
bmbouter
reviewed
Aug 12, 2020
pulp_ansible/app/models.py
Outdated
| @@ -256,6 +256,8 @@ class AnsibleRepository(Repository): | |||
| class Meta: | |||
| default_related_name = "%(app_label)s_%(model_name)s" | |||
|
|
|||
| permissions = (("modify_ansible_repo_content", "Modify Ansible Repository Content"),) | |||
There was a problem hiding this comment.
I didn't realize it when I susggested this name, but there is a naming conventions Permissions use. As is this reads in the list like this:
'Can add ansible repository',
'Can change ansible repository',
'Can delete ansible repository',
'Modify Ansible Repository Content',
'Can view ansible repository',
'Can add collection',
'Can change collection',
'Can delete collection',
So I think the name should be "Can modify ansible repository content".
There was a problem hiding this comment.
For the "codename" (the slug version) that list currently reads like:
'change_ansiblerepository',
'delete_ansiblerepository',
'modify_ansible_repo_content',
'view_ansiblerepository',
'add_collection',
'change_collection',
'delete_collection',
I think what we have right now is good.
newswangerd
force-pushed
the
add-repo-perms
branch
from
f7b503f
to
c9a945a
Compare
bmbouter
reviewed
Aug 12, 2020
| operations = [ | ||
| migrations.AlterModelOptions( | ||
| name='ansiblerepository', | ||
| options={'default_related_name': '%(app_label)s_%(model_name)s', 'permissions': (('modify_ansible_repo_content', 'Modify Ansible Repository Content'),)}, |
There was a problem hiding this comment.
This also needs the new string or the db will be incorrect.
newswangerd
force-pushed
the
add-repo-perms
branch
from
c9a945a
to
9923ebc
Compare
bmbouter
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
modify_ansible_repo_contentto theAnsibleRepositorymodel.