Small changes to match current best practices #527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fao89 I meant to make this a draft, could you update it? This won't merge until after 3.11, it's only for testing purposes right now. |
|
WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue. |
done! |
|
CI failure is unrelated apparently, will rebase after #526 |
CI is fixed now! |
dralley
force-pushed
the
abstract-field-migration
branch
from
2587da2
to
cb8729a
Compare
dralley
force-pushed
the
abstract-field-migration
branch
from
cb8729a
to
bc27a2b
Compare
dralley
changed the title
Required PR: pulp/pulpcore#1229 [noissue]
dralley
force-pushed
the
abstract-field-migration
branch
from
bc27a2b
to
39939df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[noissue]