Forbid the methods PATCH and PUT for push repositories #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubosmj
added a commit
to lubosmj/pulpcore
that referenced
this pull request
Jul 20, 2020
Required by pulp/pulp_container#127. [noissue]
|
Attached issue: https://pulp.plan.io/issues/7013 |
lubosmj
force-pushed
the
forbid-push-repo-update-7013
branch
from
163e229
to
b687fcd
Compare
mdellweg
reviewed
Jul 21, 2020
pulp_container/app/viewsets.py
Outdated
| @@ -401,9 +404,27 @@ class ContainerRepositoryVersionViewSet(RepositoryVersionViewSet): | |||
| parent_viewset = ContainerRepositoryViewSet | |||
|
|
|||
|
|
|||
| class ContainerPushRepositoryViewSet(RepositoryViewSet): | |||
| class NoUpdateRepositoryViewSet( | |||
There was a problem hiding this comment.
Just an idea: How about ImmutableRepositoryViewSet?
lubosmj
added a commit
to lubosmj/pulpcore
that referenced
this pull request
Jul 22, 2020
Required by pulp/pulp_container#127. closes #7191
lubosmj
force-pushed
the
forbid-push-repo-update-7013
branch
3 times, most recently
from
94db9a4
to
0eed716
Compare
lubosmj
added a commit
to lubosmj/pulpcore
that referenced
this pull request
Jul 22, 2020
Required by pulp/pulp_container#127. closes #7191
|
This PR will be converted back to a normal PR after the next release of pulpcore. Refer to pulp/pulpcore#795 to learn more. |
lubosmj
force-pushed
the
forbid-push-repo-update-7013
branch
from
0eed716
to
030cf92
Compare
mdellweg
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7013