Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RBAC for container remotes. #183

Merged
merged 1 commit into from Dec 11, 2020
Merged

Add RBAC for container remotes. #183

merged 1 commit into from Dec 11, 2020

Conversation

ipanova
Copy link
Member

@ipanova ipanova commented Dec 7, 2020

closes #7707

@pulpbot
Copy link
Member

pulpbot commented Dec 7, 2020

Attached issue: https://pulp.plan.io/issues/7707

mdellweg
mdellweg reviewed Dec 8, 2020
View reviewed changes
Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good to me.
Do we have a blueprint how to test RBAC related changes?

@ipanova
Copy link
Member Author

ipanova commented Dec 9, 2020 •
edited

This looks very good to me.
Do we have a blueprint how to test RBAC related changes?

When reviewing the core pr for rbac we used to test tasks. I would use same approach for testing other objects as well pulp/pulpcore#815 (comment)

Actually, maybe it's worth even adding docs on how to test and be sure that added policies work as expected.

@mdellweg
Copy link
Member

mdellweg commented Dec 9, 2020

Sadly there is not a functional test example...

@ipanova ipanova merged commit d192e64 into pulp:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdellweg mdellweg mdellweg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ipanova @pulpbot @mdellweg