Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI + enable https #304

Merged
merged 1 commit into from Jul 30, 2021
Merged

Update CI + enable https #304

merged 1 commit into from Jul 30, 2021

Conversation

fao89
Copy link
Member

@fao89 fao89 commented May 3, 2021

[noissue]

@pulpbot
Copy link
Member

pulpbot commented May 3, 2021

WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue.

@fao89 fao89 force-pushed the https branch 8 times, most recently from 0b0e00d to b65c6fc Compare May 6, 2021 00:11
@ipanova
Copy link
Member

ipanova commented May 6, 2021

🎉

@fao89
Copy link
Member Author

fao89 commented Jun 3, 2021

Blocked by pulp/pulp-oci-images#73 or pulp/pulp-oci-images#84

@fao89
Copy link
Member Author

fao89 commented Jul 26, 2021

@pulp/container-plugin I merged the SSL changes, I rebased this PR, but it is broken.
From the logs, I couldn't understand what is happening, I need help to understand how to fix it

@mdellweg
Copy link
Member

"413 Request Entity Too Large" There is some max_request_body_size (or similar) that needs to be increased i think.

@ipanova
Copy link
Member

ipanova commented Jul 27, 2021

413 Request Entity Too Large

it 'is client_max_body_size in the nginx setting. the default value is set to 1m

@fao89
Copy link
Member Author

fao89 commented Jul 27, 2021

from SSL single container image:

location /pulp/api/v3/ {
            proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
            proxy_set_header X-Forwarded-Proto $scheme;
            proxy_set_header Host $http_host;
            # we don't want nginx trying to do something clever with
            # redirects, we set the Host: header above already.
            proxy_redirect off;
            proxy_pass http://pulp-api;
            client_max_body_size 10m;
        }

https://github.com/pulp/pulp-oci-images/blob/latest/assets/ssl_nginx.conf#L75

@fao89 fao89 force-pushed the https branch 2 times, most recently from c5d0937 to 902a593 Compare July 27, 2021 13:47
@fao89
Copy link
Member Author

fao89 commented Jul 27, 2021

The issue is here: https://github.com/pulp/plugin_template/blob/master/templates/github/.ci/ansible/Containerfile.j2.copy#L26-L27
it wasn't copying the nginx snippet

@fao89
Copy link
Member Author

fao89 commented Jul 27, 2021

it is ready for review now!

@ipanova
Copy link
Member

ipanova commented Jul 29, 2021

Thank you @fao89 , this looks good to me! @mdellweg can you take a look as well?

@ipanova ipanova merged commit e9bbfec into pulp:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants