Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ProgressBar with ProgressReport #117

Merged
merged 1 commit into from Sep 20, 2019
Merged

Replace ProgressBar with ProgressReport #117

merged 1 commit into from Sep 20, 2019

Conversation

fao89
Copy link
Member

@fao89 fao89 commented Sep 18, 2019

Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabricio-aguiar This does not look scary at all, but somehow the tests fail. Do you have an idea, why? Is it some migrations thing?

@fao89
Copy link
Member Author

fao89 commented Sep 19, 2019

@fabricio-aguiar This does not look scary at all, but somehow the tests fail. Do you have an idea, why? Is it some migrations thing?

after I opened this PR yesterday I realize a migration conflict on the pulpcore PR, I've fixed the conflict, maybe the tests will pass now

Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reran the tests. Now green.
Merging must be coordinated though?

@fao89
Copy link
Member Author

fao89 commented Sep 19, 2019

Reran the tests. Now green.
Merging must be coordinated though?

Yes, it will be merged tomorrow, after merge the required PRs

@bmbouter bmbouter merged commit 0ef369b into pulp:master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants