Switch to using PublishedMetada.create_from_file() #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkliban
force-pushed
the
publishedmetadata
branch
2 times, most recently
from
17642be
to
2dd366e
Compare
mdellweg
reviewed
Sep 26, 2019
CHANGES/5304.misc
Outdated
| Required PR: https://github.com/pulp/pulpcore/pull/303/ | ||
|
|
||
| re: #5304 | ||
| https://pulp.plan.io/issues/5304 |
There was a problem hiding this comment.
this sounds like the information to go in the commit message.
| publication=publication, | ||
| file=File(open(package_index_path, "rb")), | ||
| package_index = PublishedMetadata.create_from_file( | ||
| publication=publication, file=File(open(package_index_path, "rb")) |
There was a problem hiding this comment.
How is the relative_path determined in this PublishedMetadata?
There was a problem hiding this comment.
If the relative_path is passed in to create_from_file, then that value is used. If it is not passed in, the file name from the file object is used.
dkliban
force-pushed
the
publishedmetadata
branch
from
2dd366e
to
2baf615
Compare
mdellweg
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required PR: pulp/pulpcore#303
re: #5304
https://pulp.plan.io/issues/5304