Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bindings installation on dev environment #162

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Bindings installation on dev environment #162

merged 1 commit into from
Mar 25, 2020

Conversation

fao89
Copy link
Member

@fao89 fao89 commented Mar 19, 2020

quba42
quba42 approved these changes Mar 25, 2020
View reviewed changes
Copy link
Collaborator

@quba42 quba42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation is always good, and this LGTM.

@mdellweg Any objections to merging this soon?

mdellweg
mdellweg approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is this coming from plugin_template?

@fao89
Copy link
Member Author

fao89 commented Mar 25, 2020

I guess this is this coming from plugin_template?

it did not come from plugin_template, I just thought it would be nice to have this doc matching with pulpcore: pulp/pulpcore#598

@mdellweg
Copy link
Member

So should it be in plugin_template, too?

@mdellweg mdellweg merged commit d887c32 into pulp:master Mar 25, 2020
@mdellweg
Copy link
Member

Thank you @fabricio-aguiar !

@fao89
Copy link
Member Author

fao89 commented Mar 25, 2020

So should it be in plugin_template, too?

good point! I think it could be valuable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quba42 quba42 quba42 approved these changes

@mdellweg mdellweg mdellweg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fao89 @mdellweg @quba42