New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix APT client installing patches #184
Conversation
Attached issue: https://pulp.plan.io/issues/6982 |
@@ -202,7 +202,7 @@ class BasePackage822Serializer(SingleArtifactContentSerializer): | |||
"bugs": "Bugs", | |||
"essential": "Essential", | |||
"build_essential": "Build_essential", | |||
"installed_size": "Installed_size", | |||
"installed_size": "Installed-Size", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just comparing the lines above and below here... Are you sure it's going to be a dash instead of that underscore? I can see that the capital "S" might have been the problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I double checked Package file of remote repositories and its dash and not underscore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So during testing we found that this does in fact appear to solve the issue for some upstream repositories, but not for others...
Synchronizing a remote with distributions="bionic" url="http://deb.tuxedocomputers.com/ubuntu/"
resulted in Package indices with Installed-Size
fields, but a remote with distributions="experimental" components="contrib" architectures="amd64" url="http://ftp.de.debian.org/debian/"
resulted in Package indices that lost the Installed-Size
fields that were present in the upstream repo...
This needs some further investigation before this can be merged...
Pretty weird...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad! It appears the repos that were not working before are now working after I did a pclean
.
Not sure why that was necessary but the problems appear to have been a fluke of my development environment.
fixes APT client installing same packages again and again due to missing installed_size.
fixes #6982
https://pulp.plan.io/issues/6982