Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.

Renaming base fields #424

Merged
merged 4 commits into from
Oct 9, 2019
Merged

Renaming base fields #424

merged 4 commits into from
Oct 9, 2019

Conversation

fao89
Copy link
Member

@fao89 fao89 commented Oct 3, 2019

_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

ref #5457
https://pulp.plan.io/issues/5457

Required PR: pulp/pulpcore#317
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220

@pep8speaks
Copy link

pep8speaks commented Oct 3, 2019

Hello @fabricio-aguiar! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-10-09 23:17:32 UTC

@fao89 fao89 changed the title 5454and5457 Renaming base fields Oct 3, 2019
@fao89 fao89 force-pushed the 5454and5457 branch 2 times, most recently from 57684e3 to 9f2254b Compare October 4, 2019 13:50
Copy link
Member

@ipanova ipanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@fao89 fao89 force-pushed the 5454and5457 branch 10 times, most recently from d79e69e to 2b4f373 Compare October 9, 2019 22:11
fao89 and others added 4 commits October 9, 2019 19:43
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

ref #5457
https://pulp.plan.io/issues/5457
@fao89
Copy link
Member Author

fao89 commented Oct 9, 2019

@ipanova if you don't find it green, locally the request was None breaking here: https://github.com/pulp/pulp_docker/blob/master/pulp_docker/app/serializers.py#L113

@ipanova
Copy link
Member

ipanova commented Oct 9, 2019

@fabricio-aguiar that's a bug we have already opened, travis was green! so i merged, thank you for working on this!

@ipanova ipanova merged commit 5cefa8d into pulp:master Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants