This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Retry download docker blob when connection dropped #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
hao-yu
force-pushed
the
fixes_6471_retry_download_docker_blob
branch
from
3c86dd7
to
18f8f6d
Compare
hao-yu
force-pushed
the
fixes_6471_retry_download_docker_blob
branch
from
18f8f6d
to
2661483
Compare
|
@ipanova Is this patch ok to proceed? |
|
@hao-yu Thank you for the PR. Pulp should not keep hitting on the server if the server dropped the connection. There is a ticket opened with IT to solve issue on the server side. |
|
@ipanova just wondering is that any plan to reconsider this patch? Or Pulp team has other plan to fix the Jira issue? |
|
@hao-yu @midnightercz submitted a patch to nectar. It should solve the issue. Will you be able to help review and test it on the Satellite side? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When syncing large docker repositories from a Red Hat registry (http://registry.redhat.io), the docker downloads will fail with connection reset by peer. This patch lets the docker plugin to retry the blob download when hitting the connection drop issue so that the task can be finished successfully.
closes #6471
https://pulp.plan.io/issues/6471