Run pulpcore functional tests as part of the Travis job #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dralley
reviewed
Sep 12, 2018
.travis/script.sh
Outdated
| @@ -30,6 +30,10 @@ show_logs_and_return_non_zero() { | |||
| } | |||
| pytest -v -r sx --color=yes --pyargs pulp_file.tests.functional || show_logs_and_return_non_zero | |||
|
|
|||
| # test against pulpcore as well since pulpcore has a set of tests which use pulp_file | |||
| cd ../pulp | |||
| pytest -v -r sx --color=yes --pyargs tests.functional || show_logs_and_return_non_zero | |||
There was a problem hiding this comment.
You can make it more specific and just run tests.functional.api.using_plugin
daviddavis
force-pushed
the
issue4000
branch
2 times, most recently
from
13a17ec
to
2301284
Compare
Since pulpcore functional tests use pulp_file, a change in pulp_file could break these tests. closes #4000 https://pulp.plan.io/issues/4000
daviddavis
force-pushed
the
issue4000
branch
from
2301284
to
a15f524
Compare
|
Ping @pulp/qe |
dralley
approved these changes
Sep 12, 2018
nixocio
approved these changes
Sep 12, 2018
rochacbruno
approved these changes
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since pulpcore functional tests use pulp_file, a change in pulp_file could break these tests. Therefore, we need to run pulpcore tests against pulp_file PRs.
closes #4000
https://pulp.plan.io/issues/4000