Adds lazy download support #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Nov 14, 2018
Required PR: pulp/pulp_file#132 This includes a serializer that validates input correctly. https://pulp.plan.io/issues/3763 closes pulp#3763
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Nov 14, 2018
Required PR: pulp/pulp_file#132 This includes a serializer that validates input correctly. https://pulp.plan.io/issues/3763 closes pulp#3763
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Nov 20, 2018
Required PR: pulp/pulp_file#132 This includes a serializer that validates input correctly. This also switches the finalize, write_data, and handle_headers callbacks to be coroutines themselves. This is required because within those callbacks the streamer needs to await on coroutines and that can only be done from withing a coroutine itself. https://pulp.plan.io/issues/3763 closes pulp#3763
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Nov 20, 2018
Required PR: pulp/pulp_file#132 This includes a serializer that validates input correctly. This also switches the finalize, write_data, and handle_headers callbacks to be coroutines themselves. This is required because within those callbacks the streamer needs to await on coroutines and that can only be done from withing a coroutine itself. This also adjusts the Remote.get_downloader() method signature to take `url` or `remote_artifact` as kwargs instead of `url` as a positional parameter. This allows plugin writers (and the streamer) to get downloaders configured with digest and size validation automatically from remote_artifacts. https://pulp.plan.io/issues/3763 closes pulp#3763
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Nov 27, 2018
Required PR: pulp/pulp_file#132 This includes a serializer that validates input correctly. This also switches the finalize, write_data, and handle_headers callbacks to be coroutines themselves. This is required because within those callbacks the streamer needs to await on coroutines and that can only be done from withing a coroutine itself. This also adjusts the Remote.get_downloader() method signature to take `url` or `remote_artifact` as kwargs instead of `url` as a positional parameter. This allows plugin writers (and the streamer) to get downloaders configured with digest and size validation automatically from remote_artifacts. https://pulp.plan.io/issues/3763 closes pulp#3763
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Nov 29, 2018
Required PR: pulp/pulp_file#132 This includes a serializer that validates input correctly. This also switches the finalize, write_data, and handle_headers callbacks to be coroutines themselves. This is required because within those callbacks the streamer needs to await on coroutines and that can only be done from withing a coroutine itself. This also adjusts the Remote.get_downloader() method signature to take `url` or `remote_artifact` as kwargs instead of `url` as a positional parameter. This allows plugin writers (and the streamer) to get downloaders configured with digest and size validation automatically from remote_artifacts. https://pulp.plan.io/issues/3763 closes pulp#3763
jortel
reviewed
Nov 30, 2018
| dv = DeclarativeVersion(first_stage, repository, mirror=mirror) | ||
| else: | ||
| dv = DeclarativeVersion(first_stage, repository, mirror=mirror, download_artifacts=False) | ||
| dv.create() |
There was a problem hiding this comment.
Suggest:
download_artifacts = (remote.policy == POLICY_MODE.IMMEDIATE)
dv = DeclarativeVersion(first_stage, repository, mirror=mirror, download_artifacts=download_artifacts)
to reduce code duplication.
Let's compare using the constants.POLICY_MODE instead of the string literal.
There was a problem hiding this comment.
For me to use POLICY_MODE here I would need to import from pulpcore.constants which a plugin should not do directly. We need this to be in the plugin API somewhere. Maybe we should just import them through pulpcore.plugin.constants?
There was a problem hiding this comment.
Actually the Django docs show putting these types of things on the models themselves. After just importing a bunch of things "through" the plugin API, it seems easier just to do that instead. What about that?
There was a problem hiding this comment.
Yeah, having the constants on a model would be good.
There was a problem hiding this comment.
Ok I'll do that, thanks.
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Nov 30, 2018
Required PR: pulp/pulp_file#132 This includes a serializer that validates input correctly. This also switches the finalize, write_data, and handle_headers callbacks to be coroutines themselves. This is required because within those callbacks the streamer needs to await on coroutines and that can only be done from withing a coroutine itself. This also adjusts the Remote.get_downloader() method signature to take `url` or `remote_artifact` as kwargs instead of `url` as a positional parameter. This allows plugin writers (and the streamer) to get downloaders configured with digest and size validation automatically from remote_artifacts. https://pulp.plan.io/issues/3763 closes pulp#3763
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Nov 30, 2018
Required PR: pulp/pulp_file#132 This includes a serializer that validates input correctly. This also switches the finalize, write_data, and handle_headers callbacks to be coroutines themselves. This is required because within those callbacks the streamer needs to await on coroutines and that can only be done from withing a coroutine itself. This also adjusts the Remote.get_downloader() method signature to take `url` or `remote_artifact` as kwargs instead of `url` as a positional parameter. This allows plugin writers (and the streamer) to get downloaders configured with digest and size validation automatically from remote_artifacts. https://pulp.plan.io/issues/3763 closes pulp#3763
Required PR: pulp/pulp#3738 pulp_file now meaningfully uses the 'policy' attribute when syncing content. This is meant to be used with this PR: pulp/pulp#3738 https://pulp.plan.io/issues/4160 closes #4160
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Nov 30, 2018
Required PR: pulp/pulp_file#132 This includes a serializer that validates input correctly. This also switches the finalize, write_data, and handle_headers callbacks to be coroutines themselves. This is required because within those callbacks the streamer needs to await on coroutines and that can only be done from withing a coroutine itself. This also adjusts the Remote.get_downloader() method signature to take `url` or `remote_artifact` as kwargs instead of `url` as a positional parameter. This allows plugin writers (and the streamer) to get downloaders configured with digest and size validation automatically from remote_artifacts. https://pulp.plan.io/issues/3763 closes pulp#3763
jortel
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required PR: pulp/pulp#3738
pulp_file now meaningfully uses the 'policy' attribute when syncing
content.
This is meant to be used with this PR:
pulp/pulp#3738
https://pulp.plan.io/issues/4160
closes #4160