Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the publish endpoint to publications #207

Merged
merged 1 commit into from Apr 29, 2019
Merged

Move the publish endpoint to publications #207

merged 1 commit into from Apr 29, 2019

Conversation

daviddavis
Copy link
Contributor

daviddavis pushed a commit to daviddavis/pulpcore that referenced this pull request Apr 26, 2019
Remove RepositoryPublishURLSerializer and use PublicationSerializer
f9c8a8e 
Required PR: pulp/pulpcore-plugin#93
Required PR: pulp/pulp_file#207

ref pulp#4678
https://pulp.plan.io/issues/4678
daviddavis pushed a commit to daviddavis/pulpcore that referenced this pull request Apr 26, 2019
Remove RepositoryPublishURLSerializer and use PublicationSerializer
004a3a8 
Required PR: pulp/pulpcore-plugin#93
Required PR: pulp/pulp_file#207

ref pulp#4678
https://pulp.plan.io/issues/4678
daviddavis pushed a commit to daviddavis/pulpcore that referenced this pull request Apr 26, 2019
Remove RepositoryPublishURLSerializer and use PublicationSerializer
1ebe344 
Required PR: pulp/pulpcore-plugin#93
Required PR: pulp/pulp_file#207

ref pulp#4678
https://pulp.plan.io/issues/4678
daviddavis pushed a commit to daviddavis/pulpcore that referenced this pull request Apr 26, 2019
Remove RepositoryPublishURLSerializer and use PublicationSerializer
26e9688 
Required PR: pulp/pulpcore-plugin#93
Required PR: pulp/pulp_file#207

ref pulp#4678
https://pulp.plan.io/issues/4678
daviddavis pushed a commit to daviddavis/pulpcore that referenced this pull request Apr 26, 2019
Remove RepositoryPublishURLSerializer and use PublicationSerializer
f3f92c5 
Required PR: pulp/pulpcore-plugin#93
Required PR: pulp/pulp_file#207

ref pulp#4678
https://pulp.plan.io/issues/4678
@daviddavis daviddavis requested a review from a team April 26, 2019 14:52
@daviddavis daviddavis force-pushed the issue4678 branch 2 times, most recently from 6124254 to 0191bd8 Compare April 26, 2019 15:01
daviddavis pushed a commit to daviddavis/pulp-certguard that referenced this pull request Apr 26, 2019
Update tests based on publication path change
b19b595 
ref #4720
https://pulp.plan.io/issues/4720

Required PR: pulp/pulpcore-plugin#93
Required PR: https://github.com/pulp/pulpcore/pull/103/files
Required PR: pulp/pulp_file#207
@daviddavis daviddavis mentioned this pull request Apr 26, 2019
Merged
daviddavis pushed a commit to daviddavis/pulpcore that referenced this pull request Apr 26, 2019
Remove RepositoryPublishURLSerializer and use PublicationSerializer
14195e9 
Required PR: pulp/pulpcore-plugin#93
Required PR: pulp/pulp_file#207
Required PR: pulp/pulp-certguard#19

ref pulp#4678
https://pulp.plan.io/issues/4678
daviddavis pushed a commit to daviddavis/pulp-certguard that referenced this pull request Apr 26, 2019
Update tests based on publication path change
332c171 
ref #4720
https://pulp.plan.io/issues/4720

Required PR: pulp/pulpcore-plugin#93
Required PR: https://github.com/pulp/pulpcore/pull/103/files
Required PR: pulp/pulp_file#207
daviddavis pushed a commit to daviddavis/pulp-certguard that referenced this pull request Apr 26, 2019
Update tests based on publication path change
caf2ed1 
ref #4720
https://pulp.plan.io/issues/4720

Required PR: pulp/pulpcore-plugin#93
Required PR: https://github.com/pulp/pulpcore/pull/103/files
Required PR: pulp/pulp_file#207
daviddavis pushed a commit to daviddavis/pulpcore that referenced this pull request Apr 26, 2019
Remove RepositoryPublishURLSerializer and use PublicationSerializer
0942d69 
Required PR: pulp/pulpcore-plugin#93
Required PR: pulp/pulp_file#207
Required PR: pulp/pulp-certguard#19

ref pulp#4678
https://pulp.plan.io/issues/4678
daviddavis pushed a commit to daviddavis/pulp-certguard that referenced this pull request Apr 26, 2019
Update tests based on publication path change
dc2e3e5 
ref #4720
https://pulp.plan.io/issues/4720

Required PR: pulp/pulpcore-plugin#93
Required PR: https://github.com/pulp/pulpcore/pull/103/files
Required PR: pulp/pulp_file#207
daviddavis pushed a commit to daviddavis/pulpcore that referenced this pull request Apr 26, 2019
Remove RepositoryPublishURLSerializer and use PublicationSerializer
b57cb38 
Required PR: pulp/pulpcore-plugin#93
Required PR: pulp/pulp_file#207
Required PR: pulp/pulp-certguard#19

ref pulp#4678
https://pulp.plan.io/issues/4678
daviddavis pushed a commit to daviddavis/pulpcore-plugin that referenced this pull request Apr 26, 2019
Remove RepositoryPublishURLSerializer
56e9afd 
ref #4678

Required PR: pulp/pulpcore#103
Required PR: pulp/pulp_file#207
daviddavis pushed a commit to daviddavis/pulp-certguard that referenced this pull request Apr 26, 2019
Update tests based on publication path change
0abc737 
ref #4720
https://pulp.plan.io/issues/4720

Required PR: pulp/pulpcore-plugin#93
Required PR: https://github.com/pulp/pulpcore/pull/103/files
Required PR: pulp/pulp_file#207
Required PR: pulp/pulp-openapi-generator#3
daviddavis pushed a commit to daviddavis/pulp-certguard that referenced this pull request Apr 26, 2019
Update tests based on publication path change
e48edc1 
ref #4720
https://pulp.plan.io/issues/4720

Required PR: pulp/pulpcore-plugin#93
Required PR: https://github.com/pulp/pulpcore/pull/103/files
Required PR: pulp/pulp_file#207
daviddavis pushed a commit to daviddavis/pulpcore that referenced this pull request Apr 26, 2019
Remove RepositoryPublishURLSerializer and use PublicationSerializer
4de9eda 
Required PR: pulp/pulpcore-plugin#93
Required PR: pulp/pulp_file#207
Required PR: pulp/pulp-certguard#19
Required PR: pulp/pulp-openapi-generator#3

ref pulp#4678
https://pulp.plan.io/issues/4678
daviddavis pushed a commit to daviddavis/pulpcore that referenced this pull request Apr 27, 2019
Remove RepositoryPublishURLSerializer and use PublicationSerializer
01455ce 
Required PR: pulp/pulpcore-plugin#93
Required PR: pulp/pulp_file#207
Required PR: pulp/pulp-certguard#19

ref pulp#4678
https://pulp.plan.io/issues/4678
bmbouter
bmbouter reviewed Apr 29, 2019
View reviewed changes
pulp_file/app/tasks/publishing.py
@@ -27,18 +27,26 @@ def publish(publisher_pk, repository_version_pk):
repository_version_pk (str): Create a publication from this repository version.

"""
publisher = FilePublisher.objects.get(pk=publisher_pk)
if publisher_pk:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we removing Publishers in a separate PR? IIRC, there was a ticket for that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes https://pulp.plan.io/issues/4720

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

daviddavis pushed a commit to daviddavis/pulpcore that referenced this pull request Apr 29, 2019
Remove RepositoryPublishURLSerializer and use PublicationSerializer
d13c987 
Required PR: pulp/pulpcore-plugin#93
Required PR: pulp/pulp_file#207
Required PR: pulp/pulp-certguard#19

ref pulp#4678
https://pulp.plan.io/issues/4678
bmbouter
bmbouter approved these changes Apr 29, 2019
View reviewed changes
Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks you @daviddavis !

asmacdo
asmacdo reviewed Apr 29, 2019
View reviewed changes
pulp_file/tests/functional/utils.py Outdated
@@ -91,6 +92,31 @@ def populate_pulp(cfg, url=FILE_FIXTURE_MANIFEST_URL):
return client.get(FILE_CONTENT_PATH)['results']


def create_publication(cfg, repo, version_href=None, publisher=None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommend s/create_publication/create_file_publication/

daviddavis pushed a commit to daviddavis/pulp-certguard that referenced this pull request Apr 29, 2019
Update tests based on publication path change
0e01413 
ref #4720
https://pulp.plan.io/issues/4720

Required PR: pulp/pulpcore-plugin#93
Required PR: https://github.com/pulp/pulpcore/pull/103/files
Required PR: pulp/pulp_file#207
daviddavis pushed a commit to daviddavis/pulp-certguard that referenced this pull request Apr 29, 2019
Update tests based on publication path change
54b5593 
ref #4720
https://pulp.plan.io/issues/4720

Required PR: pulp/pulpcore-plugin#93
Required PR: https://github.com/pulp/pulpcore/pull/103/files
Required PR: pulp/pulp_file#207
daviddavis pushed a commit to daviddavis/pulp-certguard that referenced this pull request Apr 29, 2019
Update tests based on publication changes
0d16b93 
ref #4720
https://pulp.plan.io/issues/4720

Required PR: pulp/pulpcore-plugin#93
Required PR: https://github.com/pulp/pulpcore/pull/103/files
Required PR: pulp/pulp_file#207
daviddavis pushed a commit to daviddavis/pulp-certguard that referenced this pull request Apr 29, 2019
Update tests based on publication changes
048e015 
ref #4720
https://pulp.plan.io/issues/4720

Required PR: pulp/pulpcore-plugin#93
Required PR: https://github.com/pulp/pulpcore/pull/103/files
Required PR: pulp/pulp_file#207
daviddavis pushed a commit to daviddavis/pulp-certguard that referenced this pull request Apr 29, 2019
Update tests based on publication changes
2a26b77 
ref #4720
https://pulp.plan.io/issues/4720

Required PR: pulp/pulpcore-plugin#93
Required PR: https://github.com/pulp/pulpcore/pull/103/files
Required PR: pulp/pulp_file#207
daviddavis pushed a commit to daviddavis/pulp-certguard that referenced this pull request Apr 29, 2019
Update tests based on publication changes
eb447e1 
ref #4720
https://pulp.plan.io/issues/4720

Required PR: pulp/pulpcore-plugin#93
Required PR: https://github.com/pulp/pulpcore/pull/103/files
Required PR: pulp/pulp_file#207
daviddavis pushed a commit to daviddavis/pulpcore that referenced this pull request Apr 29, 2019
Remove RepositoryPublishURLSerializer and use PublicationSerializer
3886e53 
Required PR: pulp/pulpcore-plugin#93
Required PR: pulp/pulp_file#207
Required PR: pulp/pulp-certguard#19

ref pulp#4678
https://pulp.plan.io/issues/4678
daviddavis pushed a commit to pulp/pulp-certguard that referenced this pull request Apr 29, 2019
@daviddavis
Update tests based on publication changes
0971bd8 
ref #4720
https://pulp.plan.io/issues/4720

Required PR: pulp/pulpcore-plugin#93
Required PR: https://github.com/pulp/pulpcore/pull/103/files
Required PR: pulp/pulp_file#207
daviddavis pushed a commit to daviddavis/pulpcore that referenced this pull request Apr 29, 2019
Remove RepositoryPublishURLSerializer and use PublicationSerializer
173de7f 
Required PR: pulp/pulpcore-plugin#93
Required PR: pulp/pulp_file#207
Required PR: pulp/pulp-certguard#19

ref pulp#4678
https://pulp.plan.io/issues/4678
@daviddavis daviddavis merged commit 11dcfa3 into pulp:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmacdo asmacdo asmacdo left review comments

@bmbouter bmbouter bmbouter approved these changes

@nixocio nixocio nixocio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@daviddavis @bmbouter @asmacdo @nixocio