Move sync from model to task #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
dkliban
reviewed
Jan 10, 2018
pulp_file/app/tasks.py
Outdated
| if not importer.feed_url: | ||
| raise ValueError(_("An importer must have a 'feed_url' attribute to sync.")) | ||
|
|
||
| new_version = models.RepositoryVersion(repository=importer.repository) |
There was a problem hiding this comment.
This needs to occur in a transaction together with adding to task.created_resources
There was a problem hiding this comment.
I implemented this change, but something was broken. To get this PR merged, I've removed this change and created another story.
https://pulp.plan.io/issues/3274
asmacdo
force-pushed
the
3260-sync-task
branch
from
1c89c07
to
47e2af7
Compare
|
pulp/pulp#3261 (merged to 3.0-dev) is required to GET and serialize the Task with CreatedResource |
dkliban
approved these changes
Jan 11, 2018
daviddavis
approved these changes
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3260
https://pulp.plan.io/issues/3260
Depends on pulp/pulp#3259