dealing with pulpcore default_related_name #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Declaring default_related_name ref #4681
fao89
added a commit
to fao89/pulpcore
that referenced
this pull request
Aug 9, 2019
Making mandatory declaring default_related_name Required PR: pulp/pulp_file#269 closes #4681
fao89
added a commit
to fao89/pulpcore
that referenced
this pull request
Aug 9, 2019
Making mandatory declaring default_related_name Required PR: pulp/pulp_file#269 Required PR: pulp/pulp-certguard#27 closes #4681
asmacdo
reviewed
Aug 12, 2019
| @@ -26,6 +26,7 @@ class FileContent(Content): | |||
| digest = models.CharField(max_length=64, null=False) | |||
|
|
|||
| class Meta: | |||
| default_related_name = "%(app_label)s_%(model_name)s" | |||
There was a problem hiding this comment.
Is there a reason we are using old style string formatting here?
There was a problem hiding this comment.
I just followed the way it was on docs
fao89
added a commit
to fao89/pulpcore
that referenced
this pull request
Aug 12, 2019
Making mandatory declaring default_related_name Required PR: pulp/pulp_file#269 Required PR: pulp/pulp-certguard#27 closes #4681
daviddavis
approved these changes
Aug 19, 2019
fao89
added a commit
to fao89/pulpcore
that referenced
this pull request
Aug 19, 2019
Making mandatory declaring default_related_name Required PR: pulp/pulp_file#269 Required PR: pulp/pulp-certguard#27 closes #4681
fao89
added a commit
to fao89/pulpcore
that referenced
this pull request
Aug 19, 2019
Making mandatory declaring default_related_name Required PR: pulp/pulp_file#269 Required PR: pulp/pulp-certguard#27 closes #4681
daviddavis
pushed a commit
to pulp/pulpcore
that referenced
this pull request
Aug 19, 2019
Making mandatory declaring default_related_name Required PR: pulp/pulp_file#269 Required PR: pulp/pulp-certguard#27 closes #4681
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declaring default_related_name
related to: pulp/pulpcore#259
ref #4681
https://pulp.plan.io/issues/4681