New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using PublishedMetada.create_from_file() #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkliban
added a commit
to dkliban/pulpcore
that referenced
this pull request
Sep 19, 2019
This patch changes PublishedMetadata into Content. This requires migrating the database. The migration that comes with this change will only work on an empty database. It will fail to migrate any existing PublishedMetadata. This is a backwards incompatible change. The PublishedArtifact now has a classmethod called 'create_from_file'. This method creates PublishedMetadata along with an Artifact, ContentArtifact, and PublishedArtifact. Required PR: pulp/pulp_file#278 closes: #5304 https://pulp.plan.io/issues/5304
fcc2aa5
to
b474284
Compare
dkliban
added a commit
to dkliban/pulpcore
that referenced
this pull request
Sep 19, 2019
This patch changes PublishedMetadata into Content. This requires migrating the database. The migration that comes with this change will only work on an empty database. It will fail to migrate any existing PublishedMetadata. This is a backwards incompatible change. The PublishedArtifact now has a classmethod called 'create_from_file'. This method creates PublishedMetadata along with an Artifact, ContentArtifact, and PublishedArtifact. Required PR: pulp/pulp_file#278 closes: #5304 https://pulp.plan.io/issues/5304
dkliban
added a commit
to dkliban/pulpcore
that referenced
this pull request
Sep 19, 2019
This patch changes PublishedMetadata into Content. This requires migrating the database. The migration that comes with this change will only work on an empty database. It will fail to migrate any existing PublishedMetadata. This is a backwards incompatible change. The PublishedArtifact now has a classmethod called 'create_from_file'. This method creates PublishedMetadata along with an Artifact, ContentArtifact, and PublishedArtifact. Required PR: pulp/pulp_file#278 closes: #5304 https://pulp.plan.io/issues/5304
dkliban
added a commit
to dkliban/pulpcore
that referenced
this pull request
Sep 23, 2019
This patch changes PublishedMetadata into Content. This requires migrating the database. The migration that comes with this change will only work on an empty database. It will fail to migrate any existing PublishedMetadata. This is a backwards incompatible change. The PublishedArtifact now has a classmethod called 'create_from_file'. This method creates PublishedMetadata along with an Artifact, ContentArtifact, and PublishedArtifact. Required PR: pulp/pulp_file#278 closes: #5304 https://pulp.plan.io/issues/5304
b474284
to
5c723d8
Compare
dkliban
added a commit
to dkliban/pulpcore
that referenced
this pull request
Sep 23, 2019
This patch changes PublishedMetadata into Content. This requires migrating the database. The migration that comes with this change will only work on an empty database. It will fail to migrate any existing PublishedMetadata. This is a backwards incompatible change. The PublishedArtifact now has a classmethod called 'create_from_file'. This method creates PublishedMetadata along with an Artifact, ContentArtifact, and PublishedArtifact. Required PR: pulp/pulp_file#278 closes: #5304 https://pulp.plan.io/issues/5304
dkliban
added a commit
to dkliban/pulpcore
that referenced
this pull request
Sep 24, 2019
This patch changes PublishedMetadata into Content. This requires migrating the database. The migration that comes with this change will only work on an empty database. It will fail to migrate any existing PublishedMetadata. This is a backwards incompatible change. The PublishedArtifact now has a classmethod called 'create_from_file'. This method creates PublishedMetadata along with an Artifact, ContentArtifact, and PublishedArtifact. Required PR: pulp/pulp_file#278 closes: #5304 https://pulp.plan.io/issues/5304
5c723d8
to
930382a
Compare
dralley
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required PR: pulp/pulpcore#303
re: #5304
https://pulp.plan.io/issues/5304