Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renaming fields #284

Merged
merged 2 commits into from Oct 9, 2019
Merged

renaming fields #284

merged 2 commits into from Oct 9, 2019

Conversation

fao89
Copy link
Member

@fao89 fao89 commented Oct 1, 2019

fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 1, 2019
@fao89
renaming fields
aa8fcd1 
closes #5454
closes #5457
https://pulp.plan.io/issues/5454
https://pulp.plan.io/issues/5457

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
@fao89 fao89 mentioned this pull request Oct 1, 2019
Merged
fao89 added a commit to fao89/pulpcore-plugin that referenced this pull request Oct 1, 2019
@fao89
renaming fields
7d39213 
closes #5454
closes #5457
https://pulp.plan.io/issues/5454
https://pulp.plan.io/issues/5457

Required PR: pulp/pulpcore#317
Required PR: pulp/pulp_file#284
dralley
dralley requested changes Oct 1, 2019
View reviewed changes
docs/workflows/publish-host.rst Outdated
@@ -13,9 +13,9 @@ Create a Publication
Publication GET Response (after task is complete)::

{
"_created": "2019-05-16T19:28:42.971611Z",
"pulp_created": "2019-05-16T19:28:42.971611Z",
"_href": "/pulp/api/v3/publications/file/file/7d5440f6-202c-4e71-ace2-14c534f6df9e/",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was decided to rename _href as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I forgot it, so I have to change pulp/pulpcore#317 also

docs/workflows/sync.rst
@@ -10,7 +10,7 @@ Create a repository ``foo``
Repository GET Response::

{
"_created": "2019-05-16T19:23:55.224096Z",
"pulp_created": "2019-05-16T19:23:55.224096Z",
"_href": "/pulp/api/v3/repositories/680f18e7-0513-461f-b067-436b03285e4c/",
"_latest_version_href": null,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think changing these (_latest_version_href, _versions_href) was explicitly discussed but we might want to do so for the same reasons. @dkliban ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussion continuing here: https://pulp.plan.io/issues/5457#note-12

docs/workflows/sync.rst Outdated
@@ -31,10 +31,10 @@ Create a new remote ``bar``
Remote GET Response::

{
"_created": "2019-05-16T19:23:56.771326Z",
"pulp_created": "2019-05-16T19:23:56.771326Z",
"_href": "/pulp/api/v3/remotes/file/file/e682efef-3974-4366-aece-a333bfaec9f3/",
"_last_updated": "2019-05-16T19:23:56.771341Z",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_last_updated need to be fixed here

fao89 added a commit to fao89/pulpcore-plugin that referenced this pull request Oct 2, 2019
@fao89
Renaming base fields
50c8aea 
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

ref #5457
https://pulp.plan.io/issues/5457
Required PR: pulp/pulpcore#317
Required PR: pulp/pulp_file#284
Required PR: pulp/pulp-smash#1220
@fao89 fao89 requested a review from a team October 2, 2019 16:07
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 2, 2019
@fao89
Renaming base fields
e2c93f0 
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

closes #5457
https://pulp.plan.io/issues/5457

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
fao89 added a commit to fao89/pulpcore-plugin that referenced this pull request Oct 2, 2019
@fao89
Renaming base fields
fd640d2 
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

ref #5457
https://pulp.plan.io/issues/5457
Required PR: pulp/pulpcore#317
Required PR: pulp/pulp_file#284
Required PR: pulp/pulp-smash#1220
fao89 added a commit to fao89/pulpcore-plugin that referenced this pull request Oct 2, 2019
@fao89
Renaming base fields
63d9744 
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

ref #5457
https://pulp.plan.io/issues/5457
Required PR: pulp/pulpcore#317
Required PR: pulp/pulp_file#284
Required PR: pulp/pulp-smash#1220
fao89 added a commit to fao89/pulpcore-plugin that referenced this pull request Oct 2, 2019
@fao89
Renaming base fields
3599ebe 
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

ref #5457
https://pulp.plan.io/issues/5457
Required PR: pulp/pulpcore#317
Required PR: pulp/pulp_file#284
Required PR: pulp/pulp-smash#1220
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 2, 2019
@fao89
Renaming base fields
ce7bf62 
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

closes #5457
https://pulp.plan.io/issues/5457

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 2, 2019
@fao89
Renaming _type to pulp_type
6bf4313 
closes #5454
https://pulp.plan.io/issues/5454

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
fao89 added a commit to fao89/plugin_template that referenced this pull request Oct 2, 2019
@fao89
Renaming base fields
55036ce 
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

ref #5457
https://pulp.plan.io/issues/5457

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
@fao89 fao89 mentioned this pull request Oct 2, 2019
Merged
fao89 added a commit to fao89/plugin_template that referenced this pull request Oct 2, 2019
@fao89
Renaming base fields
69df344 
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

ref #5457
https://pulp.plan.io/issues/5457

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
fao89 added a commit to fao89/pulp-certguard that referenced this pull request Oct 2, 2019
@fao89
Renaming base fields
804bdd7 
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

ref #5457
https://pulp.plan.io/issues/5457

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulpcore#317
@fao89 fao89 mentioned this pull request Oct 2, 2019
Merged
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 2, 2019
@fao89
Renaming base fields
2e7fa0c 
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

closes #5457
https://pulp.plan.io/issues/5457

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulp-certguard#31
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 2, 2019
@fao89
Renaming _type to pulp_type
9a1877b 
closes #5454
https://pulp.plan.io/issues/5454

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulp-certguard#31
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 4, 2019
@fao89
Renaming base fields
328111a 
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

closes #5457
https://pulp.plan.io/issues/5457

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulp-certguard#31
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 4, 2019
@fao89
Renaming _type to pulp_type
28060ea 
closes #5454
https://pulp.plan.io/issues/5454

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulp-certguard#31
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 4, 2019
@fao89
Renaming _type to pulp_type
407dc36 
closes #5454
https://pulp.plan.io/issues/5454

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulp-certguard#31
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 8, 2019
@fao89
Renaming base fields
40319c2 
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

closes #5457
https://pulp.plan.io/issues/5457

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulp-certguard#31
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 8, 2019
@fao89
Renaming _type to pulp_type
ec06eb1 
closes #5454
https://pulp.plan.io/issues/5454

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulp-certguard#31
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 8, 2019
@fao89
Renaming _type to pulp_type
9b2cd1b 
closes #5454
https://pulp.plan.io/issues/5454

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulp-certguard#31
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 8, 2019
@fao89
Renaming base fields
03c8092 
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

closes #5457
https://pulp.plan.io/issues/5457

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulp-certguard#31
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 8, 2019
@fao89
Renaming _type to pulp_type
2f6c9ae 
closes #5454
https://pulp.plan.io/issues/5454

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulp-certguard#31
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 8, 2019
@fao89
Removing _type field
77f6aaf 
closes #5550
https://pulp.plan.io/issues/5550

 Required PR: pulp/pulp_file#284
 Required PR: pulp/pulpcore-plugin#137
 Required PR: pulp/pulp-smash#1220
 Required PR: pulp/pulp-certguard#31
@daviddavis
Copy link
Contributor

This needs to be rebased.

fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 9, 2019
@fao89
Renaming base fields
e8d1312 
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

closes #5457
https://pulp.plan.io/issues/5457

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulp-certguard#31
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 9, 2019
@fao89
Renaming _type to pulp_type
91425c1 
closes #5454
https://pulp.plan.io/issues/5454

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulp-certguard#31
fao89 added a commit to fao89/pulpcore that referenced this pull request Oct 9, 2019
@fao89
Removing _type field
f3d8c79 
closes #5550
https://pulp.plan.io/issues/5550

 Required PR: pulp/pulp_file#284
 Required PR: pulp/pulpcore-plugin#137
 Required PR: pulp/pulp-smash#1220
 Required PR: pulp/pulp-certguard#31
fao89 added a commit to fao89/pulpcore-plugin that referenced this pull request Oct 9, 2019
@fao89
Renaming base fields
a58fa56 
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

ref #5457
https://pulp.plan.io/issues/5457
Required PR: pulp/pulpcore#317
Required PR: pulp/pulp_file#284
Required PR: pulp/pulp-smash#1220
fao89 added a commit to fao89/pulp-certguard that referenced this pull request Oct 9, 2019
@fao89
Renaming base fields
9230279 
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

ref #5457
https://pulp.plan.io/issues/5457

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulpcore#317
@fao89
Renaming base fields
0e71c87 
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

ref #5457
https://pulp.plan.io/issues/5457

Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulpcore#317
Required PR: pulp/pulp-smash#1220
@fao89
Removing _type field
0a63eae 
ref #5550
https://pulp.plan.io/issues/5550

Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulpcore#317
Required PR: pulp/pulp-smash#1220
fao89 added a commit to fao89/pulpcore-plugin that referenced this pull request Oct 9, 2019
@fao89
Renaming base fields
39c654e 
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

ref #5457
https://pulp.plan.io/issues/5457
Required PR: pulp/pulpcore#317
Required PR: pulp/pulp_file#284
Required PR: pulp/pulp-smash#1220
fao89 added a commit to fao89/pulp-certguard that referenced this pull request Oct 9, 2019
@fao89
Renaming base fields
67eb868 
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

ref #5457
https://pulp.plan.io/issues/5457

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulpcore#317
fao89 added a commit to fao89/pulp-certguard that referenced this pull request Oct 9, 2019
@fao89
Renaming base fields
fed597d 
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

ref #5457
https://pulp.plan.io/issues/5457

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulpcore#317
fao89 added a commit to fao89/pulp-certguard that referenced this pull request Oct 9, 2019
@fao89
Renaming base fields
f5eb240 
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

ref #5457
https://pulp.plan.io/issues/5457

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulpcore#317
daviddavis pushed a commit to pulp/pulpcore that referenced this pull request Oct 9, 2019
@fao89 @daviddavis
Renaming base fields
96bb65e 
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

closes #5457
https://pulp.plan.io/issues/5457

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulp-certguard#31
daviddavis pushed a commit to pulp/pulpcore that referenced this pull request Oct 9, 2019
@fao89 @daviddavis
Renaming _type to pulp_type
14fe483 
closes #5454
https://pulp.plan.io/issues/5454

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulp-certguard#31
daviddavis pushed a commit to pulp/pulpcore that referenced this pull request Oct 9, 2019
@fao89 @daviddavis
Removing _type field
2a62d16 
closes #5550
https://pulp.plan.io/issues/5550

 Required PR: pulp/pulp_file#284
 Required PR: pulp/pulpcore-plugin#137
 Required PR: pulp/pulp-smash#1220
 Required PR: pulp/pulp-certguard#31
@daviddavis daviddavis merged commit dd03135 into pulp:master Oct 9, 2019
daviddavis pushed a commit to pulp/pulp-certguard that referenced this pull request Oct 9, 2019
@fao89 @daviddavis
Renaming base fields
99ad773 
_id to pulp_id
_created to pulp_created
_last_updated to pulp_last_updated
_href to pulp_href

ref #5457
https://pulp.plan.io/issues/5457

Required PR: pulp/pulp_file#284
Required PR: pulp/pulpcore-plugin#137
Required PR: pulp/pulp-smash#1220
Required PR: pulp/pulpcore#317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dralley dralley dralley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fao89 @daviddavis @dralley