Update travis config #388
Merged
Update travis config #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue. |
quba42
reviewed
May 5, 2020
docs/Makefile
Outdated
| @@ -42,7 +42,7 @@ clean: | |||
| -rm -rf $(BUILDDIR)/* | |||
|
|
|||
| html: | |||
| curl -o _static/api.json "http://localhost:24817/pulp/api/v3/docs/api.json?plugin=pulp_file" | |||
| curl -o _static/api.json "http://pulp/pulp/api/v3/docs/api.json?plugin=pulp_file" | |||
There was a problem hiding this comment.
This change makes it impossible to run make html from pulplift source boxes.
Any ideas how to cover both use cases?
There was a problem hiding this comment.
We had a little discussion about it, and came up with the following:
Since we are using a mixture of shell scripts, containers, and Makefiles, it should be possible to parametrize all API calls in a uniform way using environmental variables. This would have the added benefit of reducing the reliance on sed -i for parametrization (which is a bit of a hack).
[noissue]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[noissue]