Add support for automatic publishing and distributing #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dralley
force-pushed
the
auto-publish-distribute
branch
from
ca5fd43
to
591939e
Compare
|
You have a typo--should be |
dralley
force-pushed
the
auto-publish-distribute
branch
4 times, most recently
from
d598704
to
38bb856
Compare
dralley
force-pushed
the
auto-publish-distribute
branch
from
38bb856
to
3578742
Compare
|
Attached issue: https://pulp.plan.io/issues/7469 |
dralley
force-pushed
the
auto-publish-distribute
branch
8 times, most recently
from
3fda22e
to
022e581
Compare
dralley
added a commit
to dralley/pulpcore
that referenced
this pull request
Feb 16, 2021
Required PR: pulp/pulp_file#467 closes: #7626 https://pulp.plan.io/issues/7626
dralley
force-pushed
the
auto-publish-distribute
branch
from
022e581
to
6c1f800
Compare
|
test failure is just caused by the requirement of pulpcore 3.11 which doesn't exist yet. and I suppose it doesn't think the prerelease counts |
|
Make it depend on 3.11.dev and it should be fine |
dralley
force-pushed
the
auto-publish-distribute
branch
from
6c1f800
to
c86c8b5
Compare
dralley
added a commit
to dralley/pulpcore
that referenced
this pull request
Feb 16, 2021
Required PR: pulp/pulp_file#467 closes: #7626 https://pulp.plan.io/issues/7626
dralley
commented
Feb 16, 2021
| @@ -99,6 +129,7 @@ class FilePublicationSerializer(PublicationSerializer): | |||
| manifest = serializers.CharField( | |||
There was a problem hiding this comment.
Should I remove the fields from the Publication model and proxy them through PublishSettings?
There was a problem hiding this comment.
That's a good question. I lean towards yes (to remove the duplicate data) but I don't have a strong opinion.
dralley
added a commit
to dralley/pulpcore
that referenced
this pull request
Feb 16, 2021
Required PR: pulp/pulp_file#467 closes: #7626 https://pulp.plan.io/issues/7626
dralley
added a commit
to dralley/pulpcore
that referenced
this pull request
Feb 16, 2021
Required PR: pulp/pulp_file#467 closes: #7626 https://pulp.plan.io/issues/7626
dralley
added a commit
to dralley/pulpcore
that referenced
this pull request
Feb 16, 2021
Required PR: pulp/pulp_file#467 closes: #7626 https://pulp.plan.io/issues/7626
dralley
force-pushed
the
auto-publish-distribute
branch
from
747e04c
to
6be821d
Compare
dralley
added a commit
to dralley/pulpcore
that referenced
this pull request
Feb 23, 2021
Required PR: pulp/pulp_file#467 closes: #7626 https://pulp.plan.io/issues/7626
dralley
force-pushed
the
auto-publish-distribute
branch
2 times, most recently
from
676334f
to
d3624b9
Compare
dralley
added a commit
to dralley/pulpcore
that referenced
this pull request
Feb 24, 2021
Abstract models across an API boundary between separate apps is a nightmare. Required PR: pulp/pulp_file#467 closes: #7626 https://pulp.plan.io/issues/7626
dralley
force-pushed
the
auto-publish-distribute
branch
from
d3624b9
to
7dd9d8b
Compare
dralley
added a commit
to dralley/pulpcore
that referenced
this pull request
Feb 24, 2021
Abstract models across an API boundary between separate apps is a nightmare. Required PR: pulp/pulp_file#467 closes: #7626 https://pulp.plan.io/issues/7626
dralley
added a commit
to dralley/pulpcore
that referenced
this pull request
Feb 24, 2021
Abstract models across an API boundary between separate apps is a nightmare. Required PR: pulp/pulp_file#467 closes: #7626 https://pulp.plan.io/issues/7626
dralley
force-pushed
the
auto-publish-distribute
branch
from
7dd9d8b
to
97b3b30
Compare
dralley
added a commit
to dralley/pulpcore
that referenced
this pull request
Feb 24, 2021
Abstract models across an API boundary between separate apps is a nightmare. Required PR: pulp/pulp_file#467 closes: #7626 https://pulp.plan.io/issues/7626
dralley
force-pushed
the
auto-publish-distribute
branch
2 times, most recently
from
570daea
to
4c9f374
Compare
dralley
added a commit
to dralley/pulpcore
that referenced
this pull request
Feb 24, 2021
Required PR: pulp/pulp_file#467 closes: #7626 https://pulp.plan.io/issues/7626
dralley
added a commit
to dralley/pulpcore
that referenced
this pull request
Feb 24, 2021
Abstract models across an API boundary between separate apps is a nightmare. Required PR: pulp/pulp_file#467 closes: #7626 https://pulp.plan.io/issues/7626
dralley
force-pushed
the
auto-publish-distribute
branch
from
4c9f374
to
b5ecf8b
Compare
dralley
force-pushed
the
auto-publish-distribute
branch
2 times, most recently
from
bddfeee
to
56eaaa9
Compare
mdellweg
reviewed
Mar 5, 2021
| FilePublishSettings = apps.get_model('file', 'filepublishsettings') | ||
|
|
||
| for publication in FilePublication.objects.iterator(): | ||
| publish_settings, _ = FilePublishSettings.objects.get_or_create( |
There was a problem hiding this comment.
I know, this is the recommended way to ignore partial return values. But does it work together with _ binding to gettext?
There was a problem hiding this comment.
In this particular case, there is no gettext import for it to conflict with, but in the general case, I don't know.
There was a problem hiding this comment.
I agree, gettext would make the migrations really unstable.
mdellweg
reviewed
Mar 5, 2021
| # Set the core "_publication" field with the value of the detail "publication" field | ||
| FileDistribution = apps.get_model('file', 'filedistribution') | ||
|
|
||
| distributions = list(FileDistribution.objects.all()) |
There was a problem hiding this comment.
Should we do this in chunks?
I think it would be very bad to get into troubles with memory in the middle of a migration.
There was a problem hiding this comment.
It would be really difficult to have enough distributions for that to be a problem (you'd need hundreds of thousands of them) but maybe I can write this better.
| ] | ||
|
|
||
| operations = [ | ||
| migrations.RunPython(migrate_distribution_fields), |
There was a problem hiding this comment.
Can you please provide a down migration for this (reverse_code=migrate_distribution_fields_down)?
There was a problem hiding this comment.
It looks like none of our other migrations provide down migrations, and this one would be particularly difficult since the core tables are involved also.
dralley
added a commit
to dralley/pulpcore
that referenced
this pull request
Mar 16, 2021
Required PR: pulp/pulp_file#467 closes: #7626 https://pulp.plan.io/issues/7626
dralley
added a commit
to dralley/pulpcore
that referenced
this pull request
Mar 16, 2021
Required PR: pulp/pulp_file#467 closes: #7626 https://pulp.plan.io/issues/7626
dralley
added a commit
to dralley/pulpcore
that referenced
this pull request
Mar 16, 2021
Required PR: pulp/pulp_file#467 closes: #7626 https://pulp.plan.io/issues/7626
dralley
added a commit
to dralley/pulpcore
that referenced
this pull request
Apr 2, 2021
Required PR: pulp/pulp_file#467 closes: #7626 https://pulp.plan.io/issues/7626
dralley
added a commit
to dralley/pulpcore
that referenced
this pull request
Apr 2, 2021
Required PR: pulp/pulp_file#467 closes: #7626 https://pulp.plan.io/issues/7626
dralley
force-pushed
the
auto-publish-distribute
branch
from
56eaaa9
to
8f9de1c
Compare
dralley
added a commit
to dralley/pulpcore
that referenced
this pull request
Apr 2, 2021
Required PR: pulp/pulp_file#467 closes: #7626 https://pulp.plan.io/issues/7626
Required PR: pulp/pulpcore#1084 closes: #7469 https://pulp.plan.io/issues/7469
dralley
force-pushed
the
auto-publish-distribute
branch
from
8f9de1c
to
df83e37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #7469
https://pulp.plan.io/issues/7469