Switch to RQ #72
Merged
Switch to RQ #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @bmbouter! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on May 08, 2018 at 16:46 Hours UTC |
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Apr 20, 2018
This PR does the following: * port travis to RQ * remove all celery references * install, systemd docs updates * create a custom RQ worker method for Pulp's needs * ports the status API to report on the Redis connection * port orphan cleanup tasks to work with RQ * port all pulp tasks to RQ * handle fatal error exception recording on tasks * replace apply_async_with_reservation to enqueue_with_reservation * task cancellation kills a running task correctly * work discovery, normal shutdown, and crash shutdown tested * adds settings for Redis connection to settings files * removes celery as a dependency * adds rq as a dependency There is a devel repo PR here to be used by `vagrant up` when testing this PR: pulp/devel#146 Required PR: pulp/pulp-smash#960 Required PR: pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/devel
that referenced
this pull request
Apr 20, 2018
This commit: * Removes rabbitMQ and Qpid installation * Installs, enables, and starts Redis * Updates the systemd assets to use the RQ worker syntax This PR should be tested against these core and pulp_file PRs: pulp/pulp#3454 pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/devel
that referenced
this pull request
Apr 20, 2018
This commit: * Removes rabbitMQ and Qpid installation * Installs, enables, and starts Redis * Updates the systemd assets to use the RQ worker syntax This PR modifies the environment for these changes: pulp/pulp#3454 pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/pulp-smash
that referenced
this pull request
Apr 20, 2018
The attribute name in the status API changed when RQ with Redis replaced AMQP brokers like RabbitMQ. This PR is meant to be used with these core and pulp_file PRs: pulp/pulp#3454 pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Apr 20, 2018
This PR does the following: * port travis to RQ * remove all celery references * install, systemd docs updates * create a custom RQ worker method for Pulp's needs * ports the status API to report on the Redis connection * port orphan cleanup tasks to work with RQ * port all pulp tasks to RQ * handle fatal error exception recording on tasks * replace apply_async_with_reservation to enqueue_with_reservation * task cancellation kills a running task correctly * work discovery, normal shutdown, and crash shutdown tested * adds settings for Redis connection to settings files * removes celery as a dependency * adds rq as a dependency There is a devel repo PR here to be used by `vagrant up` when testing this PR: pulp/devel#146 Required PR: pulp/pulp-smash#960 Required PR: pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/pulp-smash
that referenced
this pull request
Apr 23, 2018
The attribute name in the status API changed when RQ with Redis replaced AMQP brokers like RabbitMQ. This PR is meant to be used with these core and pulp_file PRs: pulp/pulp#3454 pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Apr 23, 2018
This PR does the following: * port travis to RQ * remove all celery references * install, systemd docs updates * create a custom RQ worker method for Pulp's needs * ports the status API to report on the Redis connection * port orphan cleanup tasks to work with RQ * port all pulp tasks to RQ * handle fatal error exception recording on tasks * replace apply_async_with_reservation to enqueue_with_reservation * task cancellation kills a running task correctly * work discovery, normal shutdown, and crash shutdown tested * adds settings for Redis connection to settings files * removes celery as a dependency * adds rq as a dependency There is a devel repo PR here to be used by `vagrant up` when testing this PR: pulp/devel#146 Required PR: pulp/pulp-smash#960 Required PR: pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Apr 23, 2018
This PR does the following: * port travis to RQ * remove all celery references * install, systemd docs updates * create a custom RQ worker method for Pulp's needs * ports the status API to report on the Redis connection * port orphan cleanup tasks to work with RQ * port all pulp tasks to RQ * handle fatal error exception recording on tasks * replace apply_async_with_reservation to enqueue_with_reservation * task cancellation kills a running task correctly * work discovery, normal shutdown, and crash shutdown tested * adds settings for Redis connection to settings files * removes celery as a dependency * adds rq as a dependency There is a devel repo PR here to be used by `vagrant up` when testing this PR: pulp/devel#146 Required PR: pulp/pulp-smash#960 Required PR: pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Apr 23, 2018
This PR does the following: * port travis to RQ * remove all celery references * install, systemd docs updates * create a custom RQ worker method for Pulp's needs * ports the status API to report on the Redis connection * port orphan cleanup tasks to work with RQ * port all pulp tasks to RQ * handle fatal error exception recording on tasks * replace apply_async_with_reservation to enqueue_with_reservation * task cancellation kills a running task correctly * work discovery, normal shutdown, and crash shutdown tested * adds settings for Redis connection to settings files * removes celery as a dependency * adds rq as a dependency There is a devel repo PR here to be used by `vagrant up` when testing this PR: pulp/devel#146 Required PR: pulp/pulp-smash#960 Required PR: pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Apr 23, 2018
Required PR: pulp/pulp-smash#960 Required PR: pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Apr 23, 2018
This PR does the following: * port travis to RQ * remove all celery references * install, systemd docs updates * create a custom RQ worker method for Pulp's needs * ports the status API to report on the Redis connection * port orphan cleanup tasks to work with RQ * port all pulp tasks to RQ * handle fatal error exception recording on tasks * replace apply_async_with_reservation to enqueue_with_reservation * task cancellation kills a running task correctly * work discovery, normal shutdown, and crash shutdown tested * adds settings for Redis connection to settings files * removes celery as a dependency * adds rq as a dependency There is a devel repo PR here to be used by `vagrant up` when testing this PR: pulp/devel#146 Required PR: pulp/pulp-smash#960 Required PR: pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Apr 23, 2018
Required PR: pulp/pulp-smash#960 Required PR: pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Apr 23, 2018
This PR does the following: * port travis to RQ * remove all celery references * install, systemd docs updates * create a custom RQ worker method for Pulp's needs * ports the status API to report on the Redis connection * port orphan cleanup tasks to work with RQ * port all pulp tasks to RQ * handle fatal error exception recording on tasks * replace apply_async_with_reservation to enqueue_with_reservation * task cancellation kills a running task correctly * work discovery, normal shutdown, and crash shutdown tested * adds settings for Redis connection to settings files * removes celery as a dependency * adds rq as a dependency There is a devel repo PR here to be used by `vagrant up` when testing this PR: pulp/devel#146 Required PR: pulp/pulp-smash#960 Required PR: pulp/pulp_file#72
dkliban
added a commit
to dkliban/pulp
that referenced
this pull request
Apr 23, 2018
Required PR: pulp/pulp_file#72
dkliban
added a commit
to dkliban/pulp
that referenced
this pull request
Apr 23, 2018
Required PR: pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Apr 23, 2018
This PR does the following: * port travis to RQ * remove all celery references * install, systemd docs updates * create a custom RQ worker method for Pulp's needs * ports the status API to report on the Redis connection * port orphan cleanup tasks to work with RQ * port all pulp tasks to RQ * handle fatal error exception recording on tasks * replace apply_async_with_reservation to enqueue_with_reservation * task cancellation kills a running task correctly * work discovery, normal shutdown, and crash shutdown tested * adds settings for Redis connection to settings files * removes celery as a dependency * adds rq as a dependency There is a devel repo PR here to be used by `vagrant up` when testing this PR: pulp/devel#146 Required PR: pulp/pulp-smash#960 Required PR: pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/devel
that referenced
this pull request
Apr 26, 2018
This commit: * Removes rabbitMQ and Qpid installation * Installs, enables, and starts Redis * Updates the systemd assets to use the RQ worker syntax This PR modifies the environment for these changes: pulp/pulp#3454 pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Apr 26, 2018
This PR does the following: * port travis to RQ * remove all celery references * install, systemd docs updates * create a custom RQ worker method for Pulp's needs * ports the status API to report on the Redis connection * port orphan cleanup tasks to work with RQ * port all pulp tasks to RQ * handle fatal error exception recording on tasks * replace apply_async_with_reservation to enqueue_with_reservation * task cancellation kills a running task correctly * work discovery, normal shutdown, and crash shutdown tested * adds settings for Redis connection to settings files * removes celery as a dependency * adds rq as a dependency There is a devel repo PR here to be used by `vagrant up` when testing this PR: pulp/devel#146 Required PR: pulp/pulp-smash#960 Required PR: pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Apr 27, 2018
This PR does the following: * port travis to RQ * remove all celery references * install, systemd docs updates * create a custom RQ worker method for Pulp's needs * ports the status API to report on the Redis connection * port orphan cleanup tasks to work with RQ * port all pulp tasks to RQ * handle fatal error exception recording on tasks * replace apply_async_with_reservation to enqueue_with_reservation * task cancellation kills a running task correctly * work discovery, normal shutdown, and crash shutdown tested * adds settings for Redis connection to settings files * removes celery as a dependency * adds rq as a dependency There is a devel repo PR here to be used by `vagrant up` when testing this PR: pulp/devel#146 Required PR: pulp/pulp-smash#960 Required PR: pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Apr 27, 2018
This PR does the following: * port travis to RQ * remove all celery references * install, systemd docs updates * create a custom RQ worker method for Pulp's needs * ports the status API to report on the Redis connection * port orphan cleanup tasks to work with RQ * port all pulp tasks to RQ * handle fatal error exception recording on tasks * replace apply_async_with_reservation to enqueue_with_reservation * task cancellation kills a running task correctly * work discovery, normal shutdown, and crash shutdown tested * adds settings for Redis connection to settings files * removes celery as a dependency * adds rq as a dependency There is a devel repo PR here to be used by `vagrant up` when testing this PR: pulp/devel#146 Required PR: pulp/pulp-smash#960 Required PR: pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
Apr 27, 2018
This PR does the following: * port travis to RQ * remove all celery references * install, systemd docs updates * create a custom RQ worker method for Pulp's needs * ports the status API to report on the Redis connection * port orphan cleanup tasks to work with RQ * port all pulp tasks to RQ * handle fatal error exception recording on tasks * replace apply_async_with_reservation to enqueue_with_reservation * task cancellation kills a running task correctly * work discovery, normal shutdown, and crash shutdown tested * adds settings for Redis connection to settings files * removes celery as a dependency * adds rq as a dependency There is a devel repo PR here to be used by `vagrant up` when testing this PR: pulp/devel#146 Required PR: pulp/pulp-smash#960 Required PR: pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/pulp-smash
that referenced
this pull request
Apr 27, 2018
The attribute name in the status API changed when RQ with Redis replaced AMQP brokers like RabbitMQ. This PR is meant to be used with these core and pulp_file PRs: pulp/pulp#3454 pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/pulp-smash
that referenced
this pull request
May 7, 2018
The attribute name in the status API changed when RQ with Redis replaced AMQP brokers like RabbitMQ. This PR is meant to be used with these core and pulp_file PRs: pulp/pulp#3454 pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/devel
that referenced
this pull request
May 7, 2018
This commit: * Removes rabbitMQ and Qpid installation * Installs, enables, and starts Redis * Updates the systemd assets to use the RQ worker syntax * Installs a specific commit of RQ to workaround a temporary RQ release issue This PR modifies the environment for these changes: pulp/pulp#3454 pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
May 7, 2018
This PR does the following: * port travis to RQ * remove all celery references * install, systemd docs updates * create a custom RQ worker method for Pulp's needs * ports the status API to report on the Redis connection * port orphan cleanup tasks to work with RQ * port all pulp tasks to RQ * handle fatal error exception recording on tasks * replace apply_async_with_reservation to enqueue_with_reservation * task cancellation kills a running task correctly * work discovery, normal shutdown, and crash shutdown tested * adds settings for Redis connection to settings files * removes celery as a dependency * adds rq as a dependency There is a devel repo PR here to be used by `vagrant up` when testing this PR: pulp/devel#146 Required PR: pulp/pulp-smash#960 Required PR: pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
May 7, 2018
This PR does the following: * port travis to RQ * remove all celery references * install, systemd docs updates * create a custom RQ worker method for Pulp's needs * ports the status API to report on the Redis connection * port orphan cleanup tasks to work with RQ * port all pulp tasks to RQ * handle fatal error exception recording on tasks * replace apply_async_with_reservation to enqueue_with_reservation * task cancellation kills a running task correctly * work discovery, normal shutdown, and crash shutdown tested * adds settings for Redis connection to settings files * removes celery as a dependency * adds rq as a dependency There is a devel repo PR here to be used by `vagrant up` when testing this PR: pulp/devel#146 Required PR: pulp/pulp-smash#960 Required PR: pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
May 7, 2018
This PR does the following: * port travis to RQ * remove all celery references * install, systemd docs updates * create a custom RQ worker method for Pulp's needs * ports the status API to report on the Redis connection * port orphan cleanup tasks to work with RQ * port all pulp tasks to RQ * handle fatal error exception recording on tasks * replace apply_async_with_reservation to enqueue_with_reservation * task cancellation kills a running task correctly * work discovery, normal shutdown, and crash shutdown tested * adds settings for Redis connection to settings files * removes celery as a dependency * adds rq as a dependency There is a devel repo PR here to be used by `vagrant up` when testing this PR: pulp/devel#146 Required PR: pulp/pulp-smash#960 Required PR: pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
May 7, 2018
This PR does the following: * port travis to RQ * remove all celery references * install, systemd docs updates * create a custom RQ worker method for Pulp's needs * ports the status API to report on the Redis connection * port orphan cleanup tasks to work with RQ * port all pulp tasks to RQ * handle fatal error exception recording on tasks * replace apply_async_with_reservation to enqueue_with_reservation * task cancellation kills a running task correctly * work discovery, normal shutdown, and crash shutdown tested * adds settings for Redis connection to settings files * removes celery as a dependency * adds rq as a dependency There is a devel repo PR here to be used by `vagrant up` when testing this PR: pulp/devel#146 Required PR: pulp/pulp-smash#960 Required PR: pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/devel
that referenced
this pull request
May 8, 2018
This commit: * Removes rabbitMQ and Qpid installation * Installs, enables, and starts Redis * Updates the systemd assets to use the RQ worker syntax * Installs a specific commit of RQ to workaround a temporary RQ release issue This PR modifies the environment for these changes: pulp/pulp#3454 pulp/pulp_file#72
* Updates Travis to use RQ worker runners * Remove usage of Celery * port apply_async_with_reservation to enqueue_with_reservation Required PR: pulp/pulp-smash#960 Required PR: pulp/pulp#3454
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
May 8, 2018
This PR does the following: * port travis to RQ * remove all celery references * install, systemd docs updates * create a custom RQ worker method for Pulp's needs * ports the status API to report on the Redis connection * port orphan cleanup tasks to work with RQ * port all pulp tasks to RQ * handle fatal error exception recording on tasks * replace apply_async_with_reservation to enqueue_with_reservation * task cancellation kills a running task correctly * work discovery, normal shutdown, and crash shutdown tested * adds settings for Redis connection to settings files * removes celery as a dependency * adds rq as a dependency There is a devel repo PR here to be used by `vagrant up` when testing this PR: pulp/devel#146 Required PR: pulp/pulp-smash#960 Required PR: pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
May 8, 2018
This PR does the following: * port travis to RQ * remove all celery references * install, systemd docs updates * create a custom RQ worker method for Pulp's needs * ports the status API to report on the Redis connection * port orphan cleanup tasks to work with RQ * port all pulp tasks to RQ * handle fatal error exception recording on tasks * replace apply_async_with_reservation to enqueue_with_reservation * task cancellation kills a running task correctly * work discovery, normal shutdown, and crash shutdown tested * adds settings for Redis connection to settings files * removes celery as a dependency * adds rq as a dependency There is a devel repo PR here to be used by `vagrant up` when testing this PR: pulp/devel#146 Required PR: pulp/pulp-smash#960 Required PR: pulp/pulp_file#72
|
@daviddavis this repo doesn't require a LGTM, but would you want to give one if you feel that is right? All the other PRs now have LGTMs including the pulp/pulp changes: pulp/pulp#3454 (review) |
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
May 8, 2018
This PR does the following: * port travis to RQ * remove all celery references * install, systemd docs updates * create a custom RQ worker method for Pulp's needs * ports the status API to report on the Redis connection * port orphan cleanup tasks to work with RQ * port all pulp tasks to RQ * handle fatal error exception recording on tasks * replace apply_async_with_reservation to enqueue_with_reservation * task cancellation kills a running task correctly * work discovery, normal shutdown, and crash shutdown tested * adds settings for Redis connection to settings files * removes celery as a dependency * adds rq as a dependency There is a devel repo PR here to be used by `vagrant up` when testing this PR: pulp/devel#146 Required PR: pulp/pulp-smash#960 Required PR: pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
May 14, 2018
This PR does the following: * port travis to RQ * remove all celery references * install, systemd docs updates * create a custom RQ worker method for Pulp's needs * ports the status API to report on the Redis connection * port orphan cleanup tasks to work with RQ * port all pulp tasks to RQ * handle fatal error exception recording on tasks * replace apply_async_with_reservation to enqueue_with_reservation * task cancellation kills a running task correctly * work discovery, normal shutdown, and crash shutdown tested * adds settings for Redis connection to settings files * removes celery as a dependency * adds rq as a dependency There is a devel repo PR here to be used by `vagrant up` when testing this PR: pulp/devel#146 Required PR: pulp/pulp-smash#960 Required PR: pulp/pulp_file#72
bmbouter
pushed a commit
to bmbouter/pulp
that referenced
this pull request
May 14, 2018
This PR does the following: * port travis to RQ * remove all celery references * install, systemd docs updates * create a custom RQ worker method for Pulp's needs * ports the status API to report on the Redis connection * port orphan cleanup tasks to work with RQ * port all pulp tasks to RQ * handle fatal error exception recording on tasks * replace apply_async_with_reservation to enqueue_with_reservation * task cancellation kills a running task correctly * work discovery, normal shutdown, and crash shutdown tested * adds settings for Redis connection to settings files * removes celery as a dependency * adds rq as a dependency There is a devel repo PR here to be used by `vagrant up` when testing this PR: pulp/devel#146 Required PR: pulp/pulp-smash#960 Required PR: pulp/pulp_file#72
bmbouter
pushed a commit
to pulp/pulp-smash
that referenced
this pull request
May 14, 2018
The attribute name in the status API changed when RQ with Redis replaced AMQP brokers like RabbitMQ. This PR is meant to be used with these core and pulp_file PRs: pulp/pulp#3454 pulp/pulp_file#72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required PR: pulp/pulp-smash#960
Required PR: pulp/pulp#3454