Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"risky-file-permissions File permissions unset or incorrect" #800

Closed
dkliban opened this issue Nov 3, 2021 · 1 comment
Closed

"risky-file-permissions File permissions unset or incorrect" #800

dkliban opened this issue Nov 3, 2021 · 1 comment
Assignees
@pavelpicka
Labels
Triaged

Comments

@dkliban
Copy link
Member

dkliban commented Nov 3, 2021

ansible lint is complaining about a bunch of file permissions.
You can see output with any PR. e.g. https://github.com/pulp/pulp_installer/pull/797/files


Check failure on line 13 in roles/pulp_common/tasks/ambiguously-named-repo.yml
GitHub Actions / core (ansible-core)

roles/pulp_common/tasks/ambiguously-named-repo.yml#L13

risky-file-permissions File permissions unset or incorrect

Check failure on line 13 in roles/pulp_common/tasks/ambiguously-named-repo.yml
GitHub Actions / core (git+https://github.com/ansible/ansible.git)

roles/pulp_common/tasks/ambiguously-named-repo.yml#L13

risky-file-permissions File permissions unset or incorrect

  ini_file:
    path: "{{ repo_file.stdout }}"
    section: "{{ __ambiguously_named_repo }}"
roles/pulp_common/tasks/install_pip.yml
  become: true
  become_user: '{{ pulp_user }}'

- name: Create pulp install dir

Check failure on line 79 in roles/pulp_common/tasks/install_pip.yml
GitHub Actions / core (ansible-core)

roles/pulp_common/tasks/install_pip.yml#L79

risky-file-permissions File permissions unset or incorrect

Check failure on line 79 in roles/pulp_common/tasks/install_pip.yml
GitHub Actions / core (git+https://github.com/ansible/ansible.git)

roles/pulp_common/tasks/install_pip.yml#L79

risky-file-permissions File permissions unset or incorrect

  file:
    path: '{{ pulp_install_dir }}'
    state: directory
        clients: "{{ pulp_install_dir }}/bin/pip"
      register: pip_pkgs

    - name: Create requirements.in file to check pulpcore/plugin compatibility

Check failure on line 125 in roles/pulp_common/tasks/install_pip.yml
GitHub Actions / core (ansible-core)

roles/pulp_common/tasks/install_pip.yml#L125

risky-file-permissions File permissions unset or incorrect

Check failure on line 125 in roles/pulp_common/tasks/install_pip.yml
GitHub Actions / core (git+https://github.com/ansible/ansible.git)

roles/pulp_common/tasks/install_pip.yml#L125

risky-file-permissions File permissions unset or incorrect

      template:
        src: templates/requirements.in.j2
        dest: "{{ pulp_install_dir }}/requirements.in"
        virtualenv_command: '{{ pulp_python_interpreter }} -m venv'
      when: pip_pkgs.packages[pulp_install_dir + '/bin/pip'].dynaconf[0].version is version("3.1.1", "<")

    - name: Create constraints file to lock the django and pulpcore version when plugins are installed

Check failure on line 293 in roles/pulp_common/tasks/install_pip.yml
GitHub Actions / core (ansible-core)

roles/pulp_common/tasks/install_pip.yml#L293

risky-file-permissions File permissions unset or incorrect

Check failure on line 293 in roles/pulp_common/tasks/install_pip.yml
GitHub Actions / core (git+https://github.com/ansible/ansible.git)

roles/pulp_common/tasks/install_pip.yml#L293

risky-file-permissions File permissions unset or incorrect

      template:
        src: "pip_constraints_for_plugins.txt.j2"
        dest: "{{ pulp_install_dir }}/pip_constraints_for_plugins.txt"
roles/pulp_common/tasks/preflight_function.yml
  become: true
  become_user: '{{ pulp_user }}'

- name: Backup currently installed packages for any potential troubleshooting purposes

Check failure on line 25 in roles/pulp_common/tasks/preflight_function.yml
GitHub Actions / core (ansible-core)

roles/pulp_common/tasks/preflight_function.yml#L25

risky-file-permissions File permissions unset or incorrect

Check failure on line 25 in roles/pulp_common/tasks/preflight_function.yml
GitHub Actions / core (git+https://github.com/ansible/ansible.git)

roles/pulp_common/tasks/preflight_function.yml#L25

risky-file-permissions File permissions unset or incorrect

  copy:
    src: '{{ pulp_install_dir }}/requirements.txt'
    dest: '{{ pulp_install_dir }}/requirements.txt.orig'
roles/pulp_common/tasks/repos.yml
      failed_when: false
      check_mode: False

    - name: Enable the CentOS PowerTools repo

Check failure on line 98 in roles/pulp_common/tasks/repos.yml
GitHub Actions / core (ansible-core)

roles/pulp_common/tasks/repos.yml#L98

risky-file-permissions File permissions unset or incorrect

Check failure on line 98 in roles/pulp_common/tasks/repos.yml
GitHub Actions / core (git+https://github.com/ansible/ansible.git)

roles/pulp_common/tasks/repos.yml#L98

risky-file-permissions File permissions unset or incorrect

      ini_file:
        path: "{{ repo_file.stdout }}"
        section: "PowerTools"
      failed_when: false
      check_mode: False

    - name: Enable the CentOS powertools repo

Check failure on line 115 in roles/pulp_common/tasks/repos.yml
GitHub Actions / core (ansible-core)

roles/pulp_common/tasks/repos.yml#L115

risky-file-permissions File permissions unset or incorrect

Check failure on line 115 in roles/pulp_common/tasks/repos.yml
GitHub Actions / core (git+https://github.com/ansible/ansible.git)

roles/pulp_common/tasks/repos.yml#L115

risky-file-permissions File permissions unset or incorrect

      ini_file:
        path: "{{ repo_file.stdout }}"
        section: "powertools"
    - ansible_facts.distribution == "CentOS"
    - ansible_facts.distribution_major_version|int >= 8

- name: "Configure {{ __pulp_pkg_repo_name }} RPM repository"

Check failure on line 129 in roles/pulp_common/tasks/repos.yml
GitHub Actions / core (ansible-core)

roles/pulp_common/tasks/repos.yml#L129

risky-file-permissions File permissions unset or incorrect

Check failure on line 129 in roles/pulp_common/tasks/repos.yml
GitHub Actions / core (git+https://github.com/ansible/ansible.git)

roles/pulp_common/tasks/repos.yml#L129

risky-file-permissions File permissions unset or incorrect

  template:
    src: pulpcore.repo.j2
    dest: /etc/yum.repos.d/pulpcore.repo
roles/pulp_database/tasks/ambiguously-named-repo.yml
  failed_when: false
  check_mode: False

- name: "Enable the {{ __ambiguously_named_repo }} repo"

Check failure on line 13 in roles/pulp_database/tasks/ambiguously-named-repo.yml
GitHub Actions / core (ansible-core)

roles/pulp_database/tasks/ambiguously-named-repo.yml#L13

risky-file-permissions File permissions unset or incorrect

Check failure on line 13 in roles/pulp_database/tasks/ambiguously-named-repo.yml
GitHub Actions / core (git+https://github.com/ansible/ansible.git)

roles/pulp_database/tasks/ambiguously-named-repo.yml#L13

risky-file-permissions File permissions unset or incorrect

  ini_file:
    path: "{{ repo_file.stdout }}"
    section: "{{ __ambiguously_named_repo }}"
@fao89 fao89 added the Triaged label Nov 17, 2021
pavelpicka added a commit to pavelpicka/pulp_installer that referenced this issue Nov 18, 2021
@pavelpicka
Explicit file permissions
f3bde58 
ansible lint require explicit file and directory permissions

[noissue]

pulp#800
@pavelpicka pavelpicka mentioned this issue Nov 18, 2021
Merged
pavelpicka added a commit to pavelpicka/pulp_installer that referenced this issue Nov 18, 2021
@pavelpicka
Explicit file permissions
14c0400 
ansible lint require explicit file and directory permissions to be set

[noissue]

pulp#800
pavelpicka added a commit to pavelpicka/pulp_installer that referenced this issue Nov 18, 2021
@pavelpicka
Explicit file permissions
447db9e 
ansible lint require explicit file and directory permissions to be set

[noissue]

pulp#800
pavelpicka added a commit to pavelpicka/pulp_installer that referenced this issue Nov 23, 2021
@pavelpicka
Explicit file permissions
2cda976 
ansible lint require explicit file and directory permissions to be set

[noissue]

pulp#800
pavelpicka added a commit to pavelpicka/pulp_installer that referenced this issue Dec 10, 2021
@pavelpicka
Explicit file permissions
a729351 
ansible lint require explicit file and directory permissions to be set

[noissue]

pulp#800
@mikedep333
Copy link
Member

Fixed via #805

ipanova pushed a commit to ipanova/pulp_installer that referenced this issue Dec 14, 2021
@pavelpicka @ipanova
Explicit file permissions
a27c362 
ansible lint require explicit file and directory permissions to be set

[noissue]

pulp#800
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavelpicka pavelpicka

Labels
Triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dkliban @mikedep333 @fao89 @pavelpicka