Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[noissue]: Include django-storages Python package in order to enable … #136

Closed
wants to merge 2 commits into from

Conversation

makesse
Copy link

@makesse makesse commented Aug 14, 2019

…S3 storage after installation

@asmacdo
Copy link
Contributor

asmacdo commented Aug 19, 2019

If we need an extra package for s3 support, I think we ought to make it an option, which would require the addition of a new ansible var. Alternatively, if we are going to install it every time, we might as well add to requirements.txt.

@bmbouter
Copy link
Member

I'm in favor of the installer option since not all users will want this dependency.

@mikedep333
Copy link
Member

I agree that it should be an installer option.

I think it should be an "extras" dependency (extras_require in setup.py), but I think the Ansible Installer should default to installing it. Let the advanced users slim down their install.

@asmacdo
Copy link
Contributor

asmacdo commented Aug 19, 2019

@makesse are you interested in making these changes? (BTW thanks for the PR!!) If you'd like to chat synchronously, ping me in #pulp-dev on freenode.

@makesse
Copy link
Author

makesse commented Aug 19, 2019

@asmacdo: you are welcome. I will try to be on IRC tomorrow, lets see if we can discuss. For me the option as proposed by @mikedep333 sounds like the best solution, as the Ansible install to me feels liks it is pitched to be your one stop shop. How do you feel about this?

@asmacdo
Copy link
Contributor

asmacdo commented Aug 19, 2019

@makesse, yeah we are aiming for 1 stop shop, so +1 @mikedep333's solution.

@bmbouter
Copy link
Member

+1 to the one stop shop w/ customization for slimming it down.

@mikedep333
Copy link
Member

@makesse How's it going with this PR? Do you need help?

@makesse
Copy link
Author

makesse commented Oct 14, 2019

@mikedep333 : work work, will schedule some time for this issue in the upcoming two weeks.

@mikedep333
Copy link
Member

@makesse Just reminding you that this is still open, and that we can help you with it.

And that we agreed on the approach:

I agree that it should be an installer option.

I think it should be an "extras" dependency (extras_require in setup.py), but I think the Ansible Installer should default to installing it. Let the advanced users slim down their install.

@mikedep333
Copy link
Member

@makesse Just reminding you that this is still open, and that we can help you with it.

@mikedep333
Copy link
Member

We are now handling this more robustly via: https://pulp.plan.io/issues/6726

@mikedep333 mikedep333 closed this Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants