Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename pulp services #161

Merged
merged 1 commit into from Oct 4, 2019
Merged

Rename pulp services #161

merged 1 commit into from Oct 4, 2019

Conversation

lubosmj
Copy link
Member

@lubosmj lubosmj commented Sep 23, 2019

Copy link
Member

@mikedep333 mikedep333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to my inline comment:

  1. Is the pulp-content script (that gets installed in the bin dir) going to stay the same name?
  2. Do we need to update the pulp/pulp container image & operator as well? The interface between the operator and the container image is command strings like "pulp-content". I do not feel this is necessary, but it would make things more consistent. It is not necessary because the image / operator exists solely for running pulp3. It would also be extra work because we are not auto-publishing pulp / pulpcore images yet (it's high on my TODO list.)
  3. Are we going to rename the roles?

roles/pulp-content/tasks/main.yml Show resolved Hide resolved
@goosemania
Copy link
Member

goosemania commented Oct 3, 2019

I submitted another PR #170 with an additional commit on top of this one to rename pulpcore-content-app to pulpcore-content.

I'm not updating other related PRs (docs) until there is an agreement that no other changes are needed.

@dkliban
Copy link
Member

dkliban commented Oct 3, 2019

In addition to my inline comment:

1. Is the `pulp-content` script (that gets installed in the bin dir) going to stay the same name?

This script should be called pulpcore-content.

2. Do we need to update the pulp/pulp container image & operator as well? The interface between the operator and the container image is command strings like "pulp-content". I do not feel this is necessary, but it would make things more consistent. It is not necessary because the image / operator exists solely for running pulp3. It would also be extra work because we are not auto-publishing pulp / pulpcore images yet (it's high on my TODO list.)

We should create a task in pulp.plan.io for this work, but it can be done later.

3. Are we going to rename the roles?

Let's open a ticket in pulp.plan.io to rename the roles and do it soon after this is merged.

@mikedep333
Copy link
Member

@goosemania Good enough, thank you.

@dkliban We'll discuss renaming this script in IRC, or the ticket.

@dralley
Copy link
Contributor

dralley commented Oct 3, 2019

If the new work is done in #170 then this PR should be closed probably

@goosemania goosemania merged commit c69124a into pulp:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants