New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename pulp services #161
Rename pulp services #161
Conversation
closes #4554 https://pulp.plan.io/issues/4554
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to my inline comment:
- Is the
pulp-contentscript (that gets installed in the bin dir) going to stay the same name? - Do we need to update the pulp/pulp container image & operator as well? The interface between the operator and the container image is command strings like "pulp-content". I do not feel this is necessary, but it would make things more consistent. It is not necessary because the image / operator exists solely for running pulp3. It would also be extra work because we are not auto-publishing pulp / pulpcore images yet (it's high on my TODO list.)
- Are we going to rename the roles?
|
I submitted another PR #170 with an additional commit on top of this one to rename pulpcore-content-app to pulpcore-content. I'm not updating other related PRs (docs) until there is an agreement that no other changes are needed. |
This script should be called pulpcore-content.
We should create a task in pulp.plan.io for this work, but it can be done later.
Let's open a ticket in pulp.plan.io to rename the roles and do it soon after this is merged. |
|
@goosemania Good enough, thank you. @dkliban We'll discuss renaming this script in IRC, or the ticket. |
|
If the new work is done in #170 then this PR should be closed probably |
closes #4554
https://pulp.plan.io/issues/4554