Updating test matrix #213
Merged
Updating test matrix #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fao89
added a commit
to fao89/pulp_rpm_prerequisites
that referenced
this pull request
Jan 29, 2020
Required PR: pulp/pulp_installer#213 https://pulp.plan.io/issues/5768 ref #5768
fao89
added a commit
to fao89/pulp_rpm_prerequisites
that referenced
this pull request
Jan 29, 2020
Required PR: pulp/pulp_installer#213 https://pulp.plan.io/issues/5768 ref #5768
fao89
added a commit
to fao89/pulp_rpm_prerequisites
that referenced
this pull request
Jan 29, 2020
Required PR: pulp/pulp_installer#213 https://pulp.plan.io/issues/5768 ref #5768
fao89
added a commit
to fao89/pulp_rpm_prerequisites
that referenced
this pull request
Jan 29, 2020
Required PR: pulp/pulp_installer#213 https://pulp.plan.io/issues/5768 ref #5768
fao89
added a commit
to fao89/pulp_rpm_prerequisites
that referenced
this pull request
Jan 29, 2020
Required PR: pulp/pulp_installer#213 https://pulp.plan.io/issues/5768 ref #5768
mikedep333
requested changes
Jan 30, 2020
.travis.yml
Outdated
Comment on lines
18
to
34
| if: type = cron | ||
| env: TOXENV=py27 | ||
| - python: 3.6 | ||
| env: TOXENV=py36-default | ||
| env: TOXENV=py36-static | ||
| - python: 3.6 | ||
| env: TOXENV=py36-dynamic | ||
| - python: 3.6 | ||
| env: TOXENV=py36-upgrade | ||
| - python: 3.7 | ||
| if: type = cron |
There was a problem hiding this comment.
Per our convo in in the CI meeting, run everything in cron, but run this on PRs / branches:
py27-static
py36-dynamic
py37-upgrade
tox.ini
Outdated
Comment on lines
46
to
47
| # We run the upgrade tests 1st because assuming a fast internet connection, | ||
| # (to download the pre_built image of pulp 3.0.0), they take less long. |
There was a problem hiding this comment.
This comment no longer applies, correct?
It referred to when we ran 1 travis job, with upgrades followed by installs.
fao89
added a commit
to fao89/pulp_rpm_prerequisites
that referenced
this pull request
Jan 30, 2020
Required PR: pulp/pulp_installer#213 https://pulp.plan.io/issues/5768 ref #5768
fao89
added a commit
to fao89/pulp_rpm_prerequisites
that referenced
this pull request
Jan 30, 2020
Required PR: pulp/pulp_installer#213 https://pulp.plan.io/issues/5768 ref #5768
mikedep333
requested changes
Jan 31, 2020
molecule/source-upgrade/molecule.yml
Outdated
| # - idempotence # pip installing from source always replaces the installed version | ||
| - side_effect | ||
| - verify | ||
| - destroy |
There was a problem hiding this comment.
It looks like we've re-added the destroy command to the final scenario per job, which complicates debugging.
molecule/source-upgrade/molecule.yml
Outdated
| - create | ||
| - prepare | ||
| - converge | ||
| # - idempotence # pip installing from source always replaces the installed version |
There was a problem hiding this comment.
Can you move the full comment over from tox.ini?
.travis.yml
Outdated
| if: type = cron | ||
| env: TOXENV=py37-dynamic | ||
| - python: 3.7 | ||
| env: TOXENV=py37-upgrade | ||
| before_install: | ||
| - docker pull quay.io/pulp/pulp-ci-c7:3.0.0 |
There was a problem hiding this comment.
The docker pulls are only needed for the upgrade scenarios. They probably take a few to several mins.
This fell through the cracks and is originally a result of a prior PR.
mikedep333
approved these changes
Jan 31, 2020
|
Awesome, thank you very much for this big rework! |
https://pulp.plan.io/issues/5768 closes #5768
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pulp.plan.io/issues/5768
closes #5768