New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from Travis to Github actions #217
Conversation
|
@fabricio-aguiar re:
I think there's a |
The problem is, it only gets the SHA for the last commit, I found that this would bring the SHA for the range: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabricio-aguiar How about we split off the "remove Travis CI" stuff into a second PR, that we can make immediately after this one? Then we can know immediately whether the Github Actions integration works for commit checks with Pull Requests, and not break Travis until we know that it does?
|
Do you think it's worthwhile to separate out the commit validation "job" from the others? Since it runs quickly and is one of the most common things to fail a PR? It also only needs to happen once (no benefit in applying it to the matrix), and if the dev notices that if failed they probably don't even need to inspect the result to realize why it failed. |
I believe so, so far what I noticed is: travis seems like monolith and gh actions seems like microservices. I believe if we migrate to gh actions, in the future we will break many things into smaller pieces of code |
|
Thanks to @dralley now I have a replacement for TRAVIS_COMMIT_RANGE: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the name of the 1 step, LGTM!
.github/workflows/cron.yaml
Outdated
| - name: Set tox env for python 37 | ||
| if: matrix.python == '3.7' | ||
| run: echo "::set-env name=TOXENV::py37-${{ matrix.env.TEST_TYPE }}" | ||
| - name: Building images for upgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're pulling them rather than building them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Let's give it a try! 🚀
Github Actions
https://github.com/fabricio-aguiar/ansible-pulp/runs/423332526
https://github.com/fabricio-aguiar/ansible-pulp/actions/runs/33601847
* seems that all tests ran in parallel
Note:
some TRAVIS environment variables are hard to replace, like TRAVIS_COMMIT_RANGE
I still not found a way to get the commit range