Creating alias for setting minio #247
Conversation
|
This looks good to me. I left some comments. Probably should have @dkliban or @mikedep333 also review since I am unfamiliar with ansible-pulp. |
about the installation, I thought it would not be good to always install it because sometimes it won't be used |
How much overhead does it add? I'm guessing it should be minimal. |
|
To be clear, I wouldn't install/run the minio container. But other stuff like mc and django-storages, I think we could add to the devel role installation. |
| workon pulp | ||
| echo "Declaring S3 environment variables..." | ||
| sudo bash -c "echo AWS_ACCESS_KEY_ID = \'AKIAIT2Z5TDYPX3ARJBA\' >> /etc/pulp/settings.py" | ||
| sudo bash -c "echo AWS_SECRET_ACCESS_KEY = \'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\' >> /etc/pulp/settings.py" |
There was a problem hiding this comment.
Any chance you can reuse the variables you declare above ($MINIO_ACCESS_KEY and $MINIO_SECRET_KEY) here?
you are right |
| url: https://dl.min.io/client/mc/release/linux-amd64/mc | ||
| dest: /usr/local/bin | ||
| owner: '{{ developer_user }}' | ||
| mode: 0750 |
|
LGTM. Will let @dkliban or @mikedep333 review and merge. |
https://pulp.plan.io/issues/5963
closes #5963