Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate the pulp_installer CI tests: release vs source #269

Merged
merged 1 commit into from Apr 22, 2020
Merged

Separate the pulp_installer CI tests: release vs source #269

merged 1 commit into from Apr 22, 2020

Conversation

mikedep333
Copy link
Member

@mikedep333 mikedep333 commented Apr 20, 2020 •
edited

fixes: #6535

@mikedep333 mikedep333 force-pushed the 6535_separate_tests branch 11 times, most recently from ff5f27d to 3250390 Compare April 21, 2020 15:10
@mikedep333 mikedep333 requested a review from fao89 April 21, 2020 15:23
@mikedep333
Copy link
Member Author

mikedep333 commented Apr 21, 2020 •
edited

@fabricio-aguiar Do we have a GHA way of doing "Required PR"? For the prereq roles to utilize pulp_installer? I want to create PRs for galaxy_ng & pulp_rpm_prerequisites while this is a PR.

@mikedep333 mikedep333 force-pushed the 6535_separate_tests branch 2 times, most recently from 69271c2 to 45de209 Compare April 21, 2020 17:46
mikedep333 added a commit to mikedep333/pulp.pulp-rpm-prerequisites that referenced this pull request Apr 21, 2020
@mikedep333
Separate the pulp_installer CI tests: release vs source
0cb2092 
Required PR: pulp/pulp_installer#269

re: #6535

[noissue]
mikedep333 added a commit to mikedep333/pulp.pulp-rpm-prerequisites that referenced this pull request Apr 21, 2020
@mikedep333
Add basic support for "Required PR" for pulp_installer
14e3cbb 
Required PR: pulp/pulp_installer#269

[noissue]
@mikedep333 mikedep333 mentioned this pull request Apr 21, 2020
Merged
mikedep333 added a commit to mikedep333/pulp.pulp-rpm-prerequisites that referenced this pull request Apr 21, 2020
@mikedep333
Add basic support for "Required PR" for pulp_installer
10c3533 
Required PR: pulp/pulp_installer#269

[noissue]
mikedep333 added a commit to mikedep333/pulp.pulp-rpm-prerequisites that referenced this pull request Apr 21, 2020
@mikedep333
Add basic support for "Required PR" for pulp_installer
5f46241 
Required PR: pulp/pulp_installer#269

[noissue]
mikedep333 added a commit to mikedep333/pulp.pulp-rpm-prerequisites that referenced this pull request Apr 21, 2020
@mikedep333
Add basic support for "Required PR" for pulp_installer
2e6e9df 
Required PR: pulp/pulp_installer#269

[noissue]
mikedep333 added a commit to mikedep333/pulp.pulp-rpm-prerequisites that referenced this pull request Apr 21, 2020
@mikedep333
Add basic support for "Required PR" for pulp_installer
9762825 
Required PR: pulp/pulp_installer#269

[noissue]
mikedep333 added a commit to mikedep333/pulp.pulp-rpm-prerequisites that referenced this pull request Apr 21, 2020
@mikedep333
Add basic support for "Required PR" for pulp_installer
38d4d53 
Required PR: pulp/pulp_installer#269

[noissue]
mikedep333 added a commit to mikedep333/pulp.pulp-rpm-prerequisites that referenced this pull request Apr 21, 2020
@mikedep333
Separate the pulp_installer CI tests: release vs source
ccb45aa 
Required PR: pulp/pulp_installer#269

re: #6535

[noissue]
mikedep333 added a commit to mikedep333/pulp.pulp-rpm-prerequisites that referenced this pull request Apr 21, 2020
@mikedep333
Add basic support for "Required PR" for pulp_installer
6cc3abd 
Required PR: pulp/pulp_installer#269

[noissue]
mikedep333 added a commit to mikedep333/galaxy_ng_prerequisites that referenced this pull request Apr 21, 2020
@mikedep333
Separate the pulp_installer CI tests: release vs source
7ba21bf 
Required PR: pulp/pulp_installer#269

re: #6535

[noissue]
mikedep333 added a commit to mikedep333/galaxy_ng_prerequisites that referenced this pull request Apr 21, 2020
@mikedep333
Add basic support for "Required PR" for pulp_installer
363158d 
Required PR: pulp/pulp_installer#269

[noissue]
@mikedep333 mikedep333 mentioned this pull request Apr 21, 2020
Merged
mikedep333 added a commit to mikedep333/galaxy_ng_prerequisites that referenced this pull request Apr 21, 2020
@mikedep333
Utilize basic support for branches in ansible-pulp CI
552b0a2 
Required PR: pulp/pulp_installer#269

re: #6073

[noissue]
mikedep333 added a commit to mikedep333/galaxy_ng_prerequisites that referenced this pull request Apr 21, 2020
@mikedep333
Utilize basic support for branches in ansible-pulp CI
13d3688 
Required PR: pulp/pulp_installer#269

re: #6073

[noissue]
mikedep333 added a commit to mikedep333/galaxy_ng_prerequisites that referenced this pull request Apr 21, 2020
@mikedep333
Utilize basic support for branches in ansible-pulp CI
72feea1 
Required PR: pulp/pulp_installer#269

re: #6073

[noissue]
@fao89
Copy link
Member

fao89 commented Apr 22, 2020 •
edited

@fabricio-aguiar Do we have a GHA way of doing "Required PR"? For the prereq roles to utilize pulp_installer? I want to create PRs for galaxy_ng & pulp_rpm_prerequisites while this is a PR.

the Required PR is inside before_install.sh:
https://github.com/pulp/pulp_npm/blob/master/.github/before_install.sh#L27-L59

@mikedep333
Copy link
Member Author

@fabricio-aguiar Do we have a GHA way of doing "Required PR"? For the prereq roles to utilize pulp_installer? I want to create PRs for galaxy_ng & pulp_rpm_prerequisites while this is a PR.

the Required PR is inside before_install.sh:
https://github.com/pulp/pulp_npm/blob/master/.github/before_install.sh#L27-L59

Is that generated from a branch of plugin-template?

@fao89
Copy link
Member

fao89 commented Apr 22, 2020

@fabricio-aguiar Do we have a GHA way of doing "Required PR"? For the prereq roles to utilize pulp_installer? I want to create PRs for galaxy_ng & pulp_rpm_prerequisites while this is a PR.

the Required PR is inside before_install.sh:
https://github.com/pulp/pulp_npm/blob/master/.github/before_install.sh#L27-L59

Is that generated from a branch of plugin-template?

I got what plugin-template generated and modified to have github vars, as plugin-template is focused on travis. I had to do it manually, but you can use some trick like the one I did on pulp_file PR: https://github.com/pulp/pulp_file/pull/353/files#diff-60fe268f71ae7f8409aff40d0a3e51d8

mikedep333 added a commit to mikedep333/pulp.pulp-rpm-prerequisites that referenced this pull request Apr 22, 2020
@mikedep333
Add "Required PR" support for pulp_installer to prereq roles
04d57a9 
fixes: #6553

Required PR: pulp/pulp_installer#269
fao89
fao89 approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@fao89 fao89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did an amazing job with this PR!
Thanks!

.github/workflows/pull_request.yaml Outdated Show resolved Hide resolved
tox.ini Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@mikedep333
Copy link
Member Author

You did an amazing job with this PR!
Thanks!

Thank you!

I felt guilty deleting all those lines from tox.ini that you wrote, to try to maintain the previous design.

I really wanted you to review so you can confirm we will no longer need a structure like that.

mikedep333 added a commit to mikedep333/pulp.pulp-rpm-prerequisites that referenced this pull request Apr 22, 2020
@mikedep333
Add "Required PR" support for pulp_installer to prereq roles
9a94f72 
fixes: #6553

Required PR: pulp/pulp_installer#269
@fao89
Copy link
Member

fao89 commented Apr 22, 2020

You did an amazing job with this PR!
Thanks!

Thank you!

I felt guilty deleting all those lines from tox.ini that you wrote, to try to maintain the previous design.

I really wanted you to review so you can confirm we will no longer need a structure like that.

Deleting was the best part:
https://zen-of-python.info/simple-is-better-than-complex.html#3

@mikedep333 mikedep333 merged commit 7f0fb1c into pulp:master Apr 22, 2020
@mikedep333 mikedep333 deleted the 6535_separate_tests branch April 22, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fao89 fao89 fao89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikedep333 @fao89