Update nginx.conf.j2 #277
Update nginx.conf.j2 #277
Conversation
Hello! I noticed the following include: include conf.d/*.conf; Was failing, and on the conf.d directory there's a repeated conf for port 80. I believe we can exclude this include. Thanks!!!
| @@ -75,7 +75,8 @@ http { | |||
| proxy_pass http://pulp-api; | |||
| } | |||
|
|
|||
| include conf.d/*.conf; | |||
| # | |||
| # include conf.d/*.conf; | |||
There was a problem hiding this comment.
@aspoliveira1981 include conf.d/*.conf; cannot be removed, as it is used for customizing plugin URLs:
https://docs.pulpproject.org/plugins/plugin-writer/concepts/index.html#configuring-reverse-proxy-with-custom-urls
There was a problem hiding this comment.
thanks @fao89 but I wonder about the other conf files you mentioned:
[root@ip-10-2-1-88 templates]# cd /etc/nginx/conf.d/
[root@ip-10-2-1-88 conf.d]# ls
default.conf
[root@ip-10-2-1-88 conf.d]#
From this installation I just got the default.conf, maybe we need to add under the templates/ the other jinja files.
There was a problem hiding this comment.
@aspoliveira1981 can you tree /etc/nginx/ so we can more completely see the state of your system?
There was a problem hiding this comment.
[fao@localhost ~]$ ls /etc/nginx/conf.d/
pulp_ansible pulp_ansible.conf pulp_container.conf
If the repeated conf was a pulp one, just remove the conf that is without the .conf suffix
[fao@localhost ~]$ ls /etc/nginx/conf.d/
pulp_ansible.conf pulp_container.conf
|
Sure, please find it below.
[root@ip-10-2-1-88 conf.d]# tree /etc/nginx/etc/nginx|-- conf.d| `-- default.conf|-- fastcgi_params|-- koi-utf|-- koi-win|-- mime.types|-- modules -> ../../usr/lib64/nginx/modules|-- nginx.conf|-- scgi_params|-- uwsgi_params`-- win-utf
2 directories, 9 files[root@ip-10-2-1-88 conf.d]#
…-----Original Message-----
From: bmbouter <notifications@github.com>
To: pulp/pulp_installer <pulp_installer@noreply.github.com>
Cc: aspoliveira1981 <aspoliveira@aol.com>; Mention <mention@noreply.github.com>
Sent: Tue, Apr 28, 2020 5:23 pm
Subject: Re: [pulp/pulp_installer] Update nginx.conf.j2 (#277)
@bmbouter commented on this pull request.In roles/pulp-webserver/templates/nginx.conf.j2:> @@ -75,7 +75,8 @@ http {
proxy_pass http://pulp-api;
}
- include conf.d/*.conf;
+#
+# include conf.d/*.conf;
@aspoliveira1981 can you tree /etc/nginx/ so we can more completely see the state of your system?—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
@aspoliveira1981 thank you for your PR, it really helped us to address the issue, we are moving the pulp conf files to another directory: #278 |
|
thanks @fao89 , I really appreciate 😃 |
Hello! I noticed the following include:
include conf.d/*.conf;
Was failing, and on the conf.d directory there's a repeated conf for port 80.
I believe we can exclude this include (lol)
Thanks!!!