Increase the default worker count to 4 #296
Conversation
|
WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue. |
There was a problem hiding this comment.
Looks good, and definitely beneficial for our users, but I am concerned about the memory usage on CI.
We run against 3 distro containers (ansible molecule) at a time in a job, so that's 3 instances of each other process, plus now 12 instances of pulp-worker. The 8GB VM is likely swapping.
|
@mikedep333 Do you have any ideas about how we could minimize or avoid those issues? |
|
Personally I think shipping the smaller default is better. Users need to set playbook options often so users can change the |
|
In that case, I can close this issue. However, it would be really nice if the user could just specify the number of workers to create, rather than copying and pasting and changing the numbers. Would there be a way to do that? |
|
@dralley I agree it needs to be that easy. I think the user's playbook can specify: |
|
@bmbouter If you look at this PR, which uses the |
|
I think we need to make it that easy, and that is the installer improvement to make. @dralley what do you think? |
|
I definitely agree, I just wanted to be clear that I don't think we're already there :) I might have misinterpreted #296 (comment) if that wasn't what you were saying. |
|
I was wrong. I thought we were already there from the docstring that says N workers. I missed the part saying it needs a complex data structure. I filed this https://pulp.plan.io/issues/6774 and put it on the installer agenda for tomorrow. |
|
Awesome, thank you! |
|
Thank you for bringing it up! |
2 workers is quite a low default, 4 is probably more reasonable for most users.
[noissue]