Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the conflict between version and upgrade #302

Merged
merged 1 commit into from May 27, 2020
Merged

Conversation

fao89
Copy link
Member

@fao89 fao89 commented May 25, 2020

https://pulp.plan.io/issues/6669
closes #6669

Needs Action after merge

on https://readthedocs.org/ go to:
Admin > Advanced Settings > Requirements file
and type:
pulp_installer/doc_requirements.txt

@pulpbot
Copy link
Member

pulpbot commented May 25, 2020

Attached issue: https://pulp.plan.io/issues/6669

Comment on lines +19 to +20
markdown_extensions:
- pymdownx.superfences
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mkdocs.yml Outdated
@@ -1,4 +1,8 @@
site_name: Pulp Installer
site_description: Pipelines for Generating and Releasing Documentation
site_author: Pulp Team
site_url: https://pulpproject.org/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be the docs site itself? https://pulp-installer.readthedocs.io/

Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @mikedep333 what do you think?

Copy link
Member

@mikedep333 mikedep333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@bmbouter bmbouter merged commit 56c1b3e into pulp:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants