Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a pulp_installer user, I can install Pulp from RPMs #326

Merged
merged 1 commit into from Jun 16, 2020

Conversation

mikedep333
Copy link
Member

@mikedep333 mikedep333 commented Jun 9, 2020

Heavily adapted from "allow installing pulp from packages"

#188

Includes:

  1. Dropping the fixed repo from the old PR.
  2. Finish cleaning up pulp_webserver_static_dir
  3. Many new variables, but still using the overall
    pulp_install_plugins.
  4. Testing upgrades with new images on quay
    (can't truly test until RPM updates are issued)

fixes: #6793

Includes these subtasks implemented:
re: #6794
re: #6795
re: #6796
(It was easiest to implement them all in one PR.)

@pulpbot
Copy link
Member

pulpbot commented Jun 9, 2020

WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue.

@mikedep333 mikedep333 force-pushed the 6793_install_from_rpms branch 3 times, most recently from 7a30c63 to c2934b7 Compare June 10, 2020 14:54
@mikedep333 mikedep333 force-pushed the 6793_install_from_rpms branch 8 times, most recently from 4e42065 to 2b025cf Compare June 15, 2020 18:00
@mikedep333 mikedep333 changed the title WIP on 6793_install_from_rpms As a pulp_installer user, I can install Pulp from RPMs Jun 15, 2020
@mikedep333 mikedep333 requested a review from fao89 June 15, 2020 18:01
@mikedep333 mikedep333 requested a review from bmbouter June 15, 2020 18:01
CHANGES/6795.feature Outdated Show resolved Hide resolved
molecule/packages-dynamic/molecule.yml Show resolved Hide resolved
molecule/packages-static/molecule.yml Show resolved Hide resolved
molecule/packages-upgrade/molecule.yml Show resolved Hide resolved
roles/pulp/README.md Outdated Show resolved Hide resolved
roles/pulp/handlers/main.yml Show resolved Hide resolved
roles/pulp/tasks/install.yml Show resolved Hide resolved
roles/pulp_webserver/tasks/main.yml Show resolved Hide resolved
@mikedep333 mikedep333 force-pushed the 6793_install_from_rpms branch 3 times, most recently from b6d4d73 to 10ae8bd Compare June 16, 2020 16:31
@mikedep333 mikedep333 requested a review from fao89 June 16, 2020 16:32
@mikedep333
Copy link
Member Author

@fao89 I updated some of the variable descriptions as well.

Heavily adapted from "allow installing pulp from packages"

pulp#188

Includes:
1. Dropping the fixed repo from the old PR.
2. Add var pulp_pkg_repo (currently only yum/dnf)
3. Finish cleaning up pulp_webserver_static_dir
4. Many new variables, but still using the overall
pulp_install_plugins.
5. Testing upgrades with new images on quay
(can't truly test until RPM updates are issued)
6. Cron/branch CI: Adding py38 testing
7. PR CI: Move upgrade testing from py37 to py38, and testing
from RPMs on py37.
8. Deduplicating the tasks for checking plugins for nginx/apache
snippets.
9. Using pulp_django_admin_paths list var because RPMs often use
different names for django-admin.
10. Note: Rest of tasks should be package manager independent.
11. pulp_upgraded_manually variable in case users ran `yum update`
12. package only variables in seperate section of the pulp README.md.

fixes: #6793

Includes these subtasks implemented:
re: #6794
re: #6795
re: #6796
(It was easiest to implement them all in one PR.)
Copy link
Member

@fao89 fao89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @mikedep333

@mikedep333 mikedep333 merged commit 6ca8a78 into pulp:master Jun 16, 2020
@mikedep333 mikedep333 deleted the 6793_install_from_rpms branch June 16, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants