New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a pulp_installer user, I can install Pulp from RPMs #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue. |
7a30c63
to
c2934b7
Compare
4e42065
to
2b025cf
Compare
2b025cf
to
aff19d5
Compare
bmbouter
reviewed
Jun 15, 2020
bmbouter
reviewed
Jun 15, 2020
fao89
reviewed
Jun 15, 2020
fao89
reviewed
Jun 15, 2020
b6d4d73
to
10ae8bd
Compare
|
@fao89 I updated some of the variable descriptions as well. |
Heavily adapted from "allow installing pulp from packages" pulp#188 Includes: 1. Dropping the fixed repo from the old PR. 2. Add var pulp_pkg_repo (currently only yum/dnf) 3. Finish cleaning up pulp_webserver_static_dir 4. Many new variables, but still using the overall pulp_install_plugins. 5. Testing upgrades with new images on quay (can't truly test until RPM updates are issued) 6. Cron/branch CI: Adding py38 testing 7. PR CI: Move upgrade testing from py37 to py38, and testing from RPMs on py37. 8. Deduplicating the tasks for checking plugins for nginx/apache snippets. 9. Using pulp_django_admin_paths list var because RPMs often use different names for django-admin. 10. Note: Rest of tasks should be package manager independent. 11. pulp_upgraded_manually variable in case users ran `yum update` 12. package only variables in seperate section of the pulp README.md. fixes: #6793 Includes these subtasks implemented: re: #6794 re: #6795 re: #6796 (It was easiest to implement them all in one PR.)
10ae8bd
to
184f123
Compare
fao89
approved these changes
Jun 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR @mikedep333
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heavily adapted from "allow installing pulp from packages"
#188
Includes:
pulp_install_plugins.
(can't truly test until RPM updates are issued)
fixes: #6793
Includes these subtasks implemented:
re: #6794
re: #6795
re: #6796
(It was easiest to implement them all in one PR.)