pulp_devel: Implement support for signing service script #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue. |
mikedep333
force-pushed
the
rpm_signing_service
branch
from
9a5b72f
to
00cae3d
Compare
fao89
approved these changes
Jul 31, 2020
Comment on lines
+4
to
+5
| # Maintain parity with: | ||
| # https://github.com/pulp/pulp_rpm/blob/master/.travis/post_before_script.sh |
mikedep333
force-pushed
the
rpm_signing_service
branch
18 times, most recently
from
e4d7be2
to
547524d
Compare
mikedep333
commented
Aug 6, 2020
| changed_when: '"secret keys imported: 1" in result.stderr' | ||
| become: true | ||
| become_user: "{{ pulp_user }}" | ||
| when: not ansible_check_mode |
mikedep333
force-pushed
the
rpm_signing_service
branch
from
547524d
to
c25f510
Compare
mikedep333
force-pushed
the
rpm_signing_service
branch
from
c25f510
to
a476210
Compare
being copied & registered. This is in pulp_devel because the signing service is not in its permanent packaging. This is a temporary installation method. fixes: #7247 https://pulp.plan.io/issues/7247 As a pulp_installer developer-user, the pulp_rpm signing service will be installed for me Related to 4812 https://pulp.plan.io/issues/4812 As a user, I can publish a Yum repository that works with repo_gpgcheck=1 (Signed Repositories)
mikedep333
force-pushed
the
rpm_signing_service
branch
from
a476210
to
5c586f9
Compare
mikedep333
commented
Jun 2, 2021
| - name: Copy the signing service script to {{ __pulp_devel_rpm_sign_script_path }} | ||
| copy: | ||
| src: >- | ||
| {{ pulp_install_plugins_normalized['pulp-rpm'].source_dir | default (developer_user_home ~ '/devel/pulp_rpm') |
There was a problem hiding this comment.
These 3 syntax examples will be very useful in the future:
- Eliminating the outer quotes with a block
- The use of default() with a variable
- The concatenation of the variable with the string
There was a problem hiding this comment.
However, this file will only be executed, if pulp_install_plugins_normalized['pulp-rpm'].source_dir is defined...
mdellweg
reviewed
Jun 7, 2021
| {{ pulp_django_admin_path }} shell -c | ||
| "from pulpcore.app.models.content import AsciiArmoredDetachedSigningService; | ||
| AsciiArmoredDetachedSigningService.objects.create(name='sign-metadata', | ||
| script='{{ __pulp_devel_rpm_sign_script_path }}')" |
There was a problem hiding this comment.
can you try using pulpcore-manager add-signing-service here?
|
I intend to work on this at some point, but I don't want to keep the PR open. So I am going to close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
being copied & registered.
This is in pulp_devel because the signing service is not in
its permanent packaging. This is a temporary installation
method.
Fixes: #7247
https://pulp.plan.io/issues/7247
As a pulp_installer developer-user, the pulp_rpm signing service will be installed for me
Related to 4812
https://pulp.plan.io/issues/4812
As a user, I can publish a Yum repository that works with repo_gpgcheck=1 (Signed Repositories)