Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin for pre-flight #372

Closed
wants to merge 1 commit into from
Closed

Plugin for pre-flight #372

wants to merge 1 commit into from

Conversation

fao89
Copy link
Member

@fao89 fao89 commented Jul 30, 2020

@pulpbot
Copy link
Member

pulpbot commented Jul 30, 2020

WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue.

@fao89 fao89 force-pushed the pre_flight branch 7 times, most recently from 2882012 to 5435df3 Compare August 1, 2020 03:36
@fao89
Copy link
Member Author

fao89 commented Aug 1, 2020

Error message:
https://github.com/fao89/pulp_installer/runs/935896925?check_suite_focus=true#step:7:809

TASK [pulp_common : Testing the pre_flight plugin] *****************************
    Saturday 01 August 2020  19:05:18 +0000 (0:00:00.099)       0:04:59.761 *******
    pulpcore-3.5.0
    pulpcore-3.5.0
    pulpcore-3.5.0
    Checking pulp-python-3.0.0b9 compatibility
 [ERROR]: pulp-python-3.0.0b9 is not compatible with pulpcore-3.5.0 -
Requirement: pulpcore<3.5,>=3.4

    Checking pulp-python-3.0.0b9 compatibility
 [ERROR]: pulp-python-3.0.0b9 is not compatible with pulpcore-3.5.0 -
Requirement: pulpcore<3.5,>=3.4

    Checking pulp-python-3.0.0b9 compatibility
 [ERROR]: pulp-python-3.0.0b9 is not compatible with pulpcore-3.5.0 -
Requirement: pulpcore<3.5,>=3.4

    Checking pulp-file-1.1.0 compatibility
    pulp-file-1.1.0 - Ok
    Checking pulp-file-1.1.0 compatibility
    pulp-file-1.1.0 - Ok
fatal: [debian-10]: FAILED! => {}

MSG:

An unhandled exception occurred while running the lookup plugin 'pre_flight'. Error was a <class 'ansible.errors.AnsibleError'>, original message: pulp-python-3.0.0b9 is not compatible with pulpcore-3.5.0 - Requirement: pulpcore<3.5,>=3.4

@@ -1,2 +1,3 @@
[defaults]
roles_path = ~/.ansible/roles:/usr/share/ansible/roles:/etc/ansible/roles:roles
lookup_plugins = ~/.ansible/plugins/lookup:/usr/share/ansible/plugins/lookup:~/pulp_installer/plugins/lookup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we use this file? Do the molecule tests rely on this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried and molecule did not use it, I had to set a variable in molecule

RETURN = r"""
_list:
description:
- List of latest Github termsitory version(s)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that a thing? Or did your s/repos/terms/ go mad?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copied https://github.com/artis3n/ansible-collection-github and used as placeholder, I modified the code, but I still have to work on the documentation part

@fao89 fao89 requested a review from a team August 3, 2020 13:00
@fao89
Copy link
Member Author

fao89 commented Aug 3, 2020

@pulp/installer this is a PoC, it makes the collection dependent on the plugin (ansible needs to find the path to the plugin).
wdyt about this plugin for pre-flight?

Plugin for checking the compatibility of pulpcore and its plugins.
[noissue]
@fao89
Copy link
Member Author

fao89 commented Nov 25, 2020

stale for a while, closing for now

@fao89 fao89 closed this Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants