Add repr filter #382

mdellweg · 2020-08-05T07:15:39Z

No description provided.

pulpbot · 2020-08-05T07:17:17Z

WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue.

mdellweg · 2020-08-05T15:23:49Z

I switched all the dynamic scenarios to ansible 2.9 now, as ansible 2.8 does not work there.

fao89

Glad to see it tested as collection

fao89 · 2020-08-06T13:34:33Z

Makefile

@@ -0,0 +1,51 @@
+NAMESPACE := $(shell python -c 'import yaml; print(yaml.safe_load(open("galaxy.yml"))["namespace"])')


Thanks for this Makefile! It is pretty cool!

fao89 · 2020-08-06T13:36:39Z

molecule/release-static/roles

@@ -1 +0,0 @@
-../../roles


mikedep333

Also, this entire change (or 2 changes) needs a ticket or 2 in pulp.plan.io.

Even if it only affects developers, it is a very large change. Only small changes that are presumed to not be visible to users can get away without a ticket.

mikedep333 · 2020-08-10T13:30:54Z

.github/workflows/pull_request.yaml

+            ansible: "2.9"
+            python: "2.7"
+            toxpy: "27"
          - test_type: packages-dynamic
-            ansible: "2.8"
+            ansible: "2.9"


Please add a comment about the limitations of ansible 2.8.

Also, I want to have more than 1 test for python 3.8.

I do not see, where we document the dynamic use of the roles. That would be the perfect place.

@mdellweg We do not. I suppose we should create a sample playbook and page under docs, similar to the letsencrypt playbook/page I just created.

I am tempted to say, if we never announced that "feature", we'd rather not talk about it now, so we never actually need to support it.

I feel there is a whole bunch of docs we should write for the installer.

For one thing, I want this to be a section of the docs:
https://pulpproject.org/2020/07/09/pulp-3.5-installer-roles/

We should address it at that time, since it is related (running only 1 role on a each host, compared to running roles 1 at a time on a single host.)

However, I want this limitation that we are aware of, and that bit us, to be captured somewhere at least. Even a comment in the github yaml worksforme.

@mdellweg I documented it: https://github.com/pulp/pulp_installer/pull/418/files#

mikedep333 · 2020-08-10T14:12:20Z

.github/workflows/pull_request.yaml

@@ -56,8 +56,9 @@ jobs:
          python-version: ${{ matrix.python }}
      - name: Install tox
        run: |
+          sudo apt-get -yy install ansible


Why install it from apt rather than from pip? We are still reliant on pip to install the desired version.

The strangest thing: Installing ansible with pip breaks molecule in the tox venv, presumably by leaving incompatible versions of files in common directories. System (ubuntu packaged) ansible doesn't.

Wow, yeah. Please add a comment why we're doing that though. So it isn't accidentally code cleaned up.

ansible.cfg

roles/pulp_common/tasks/install_pip.yml

roles/pulp_common/templates/settings.py.j2

Makefile

mikedep333 · 2020-08-10T14:33:16Z

Makefile

+test: $(MANIFEST)
+	tox -e $(TOX_ENV)


So in order to run molecule locally, I have to build and then run a test command?

You only need to run make test. The Makefile cares for the rest.

I think you mentioned this verbally. In order for me to run freeform molecule commands, I have to run make install && molecule .... Correct?

Yes, but beware, this is the wrong pr to discuss those things. This one ought to only introduce the repr filter, and shall be rebased once #387 is merged. I think the relevant parts here are already outdated.

fao89 · 2020-08-10T14:39:57Z

Also, this entire change (or 2 changes) needs a ticket or 2 in pulp.plan.io.

Even if it only affects developers, it is a very large change. Only small changes that are presumed to not be visible to users can get away without a ticket.

we have a .dev changelog entry: https://github.com/pulp/pulp_installer/blob/master/pyproject.toml#L37

galaxy.yml

roles/pulp_common/tasks/repos.yml

requirements.yml

mikedep333 · 2020-10-26T19:49:58Z

roles/pulp_webserver/tasks/main.yml

@@ -17,8 +17,8 @@
  fail:
    msg: "If you give one of pulp_webserver_tls_cert and pulp_webserver_tls_key, you must also give the other."
  when:
-    - pulp_webserver_tls_cert | length or pulp_webserver_tls_key | length
-    - not pulp_webserver_tls_cert | length or not pulp_webserver_tls_key | length
+    - pulp_webserver_tls_cert is not mdellweg.filters.empty or pulp_webserver_tls_key is not mdellweg.filters.empty


Nice, I really like this empty filter.

https://github.com/mdellweg/ansible_filters/blob/develop/plugins/test/tests.py#L12

mikedep333 · 2021-09-29T13:24:18Z

@mdellweg Do we still want to proceed with this?

mdellweg · 2021-09-29T14:35:46Z

@mdellweg Do we still want to proceed with this?

Yes, i want to see this still. The way we generate python settings today is adventurous.

mdellweg · 2021-10-21T10:12:41Z

@mikedep333 Finally came around to touch this up.
I released a new version of the filters collection (after fixing the releng there). And i added a changelog that will eventually point to this PR. We started to adopt this pattern in pulp-cli so we didn't need to duplicate every trivial PR into an issue for the sake of changelog. If you want, we can still file one. Also, is the misc category the right one?

mdellweg · 2022-01-21T15:23:03Z

@mikedep333 ping

[noissue]

mikedep333

Awesome, thank you for this lovely refactoring!

mdellweg force-pushed the repr_filter branch 2 times, most recently from 789b6c5 to e778c98 Compare August 5, 2020 09:43

mdellweg changed the title ~~WIP: Add repr filter~~ Add repr filter Aug 5, 2020

mdellweg force-pushed the repr_filter branch 4 times, most recently from 2fa54a0 to 3a721af Compare August 5, 2020 14:54

mdellweg marked this pull request as ready for review August 5, 2020 15:27

fao89 approved these changes Aug 6, 2020

View reviewed changes

fao89 requested a review from mikedep333 August 7, 2020 20:46

mdellweg force-pushed the repr_filter branch from 3a721af to 9f49552 Compare August 10, 2020 11:25

mikedep333 requested changes Aug 10, 2020

View reviewed changes

mdellweg force-pushed the repr_filter branch from 4167315 to d03049c Compare August 12, 2020 11:30

mdellweg marked this pull request as draft August 12, 2020 11:32

mdellweg mentioned this pull request Aug 12, 2020

Test installer as a collection #387

Closed

mdellweg force-pushed the repr_filter branch 3 times, most recently from fed8fb1 to 6ec301e Compare September 25, 2020 09:20

mdellweg force-pushed the repr_filter branch from 6ec301e to 48ab5ed Compare October 26, 2020 08:04

mdellweg marked this pull request as ready for review October 26, 2020 09:54

mikedep333 requested changes Oct 26, 2020

View reviewed changes

mdellweg force-pushed the repr_filter branch from 48ab5ed to a9c65c9 Compare March 10, 2021 14:48

mdellweg force-pushed the repr_filter branch from a9c65c9 to 703ef7d Compare May 6, 2021 11:25

mdellweg force-pushed the repr_filter branch from 703ef7d to f574853 Compare October 21, 2021 10:00

fao89 requested a review from mikedep333 October 21, 2021 13:03

fao89 approved these changes Oct 28, 2021

View reviewed changes

mdellweg force-pushed the repr_filter branch from f574853 to c1c4cb7 Compare November 2, 2021 12:47

mdellweg force-pushed the repr_filter branch from c1c4cb7 to e2878eb Compare November 30, 2021 11:47

mdellweg force-pushed the repr_filter branch from e2878eb to b35ab30 Compare December 14, 2021 15:32

mdellweg force-pushed the repr_filter branch from b35ab30 to 32a3353 Compare January 2, 2022 16:02

mdellweg force-pushed the repr_filter branch from 32a3353 to 42ec954 Compare January 21, 2022 13:47

mdellweg added 2 commits February 7, 2022 13:29

Use python repr to generate settings.py

9d82f23

[noissue]

Use empty to check for undefined or ''

bc8a9a3

[noissue]

mdellweg force-pushed the repr_filter branch from 42ec954 to bc8a9a3 Compare February 7, 2022 12:29

mikedep333 approved these changes Feb 9, 2022

View reviewed changes

mdellweg merged commit a542669 into pulp:main Feb 9, 2022
13 checks passed

mdellweg deleted the repr_filter branch February 9, 2022 19:49

Add repr filter #382

Add repr filter #382

mdellweg commented Aug 5, 2020

pulpbot commented Aug 5, 2020

mdellweg commented Aug 5, 2020

fao89 left a comment

fao89 Aug 6, 2020

fao89 Aug 6, 2020

mikedep333 left a comment

mikedep333 Aug 10, 2020

mdellweg Aug 12, 2020

mikedep333 Aug 17, 2020 •

edited

mdellweg Aug 17, 2020

mikedep333 Aug 20, 2020 •

edited

mikedep333 Sep 8, 2020 •

edited

mikedep333 Aug 10, 2020

mdellweg Aug 11, 2020

mikedep333 Aug 17, 2020

mikedep333 Aug 10, 2020

mdellweg Aug 11, 2020

mikedep333 Aug 20, 2020

mdellweg Aug 20, 2020

fao89 commented Aug 10, 2020

mikedep333 Oct 26, 2020

mikedep333 commented Sep 29, 2021

mdellweg commented Sep 29, 2021

mdellweg commented Oct 21, 2021

mdellweg commented Jan 21, 2022

mikedep333 left a comment

		@@ -0,0 +1,51 @@
		NAMESPACE := $(shell python -c 'import yaml; print(yaml.safe_load(open("galaxy.yml"))["namespace"])')

		@@ -1 +0,0 @@
		../../roles

Add repr filter #382

Add repr filter #382

Conversation

mdellweg commented Aug 5, 2020

pulpbot commented Aug 5, 2020

mdellweg commented Aug 5, 2020

fao89 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mikedep333 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mikedep333 Aug 17, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mikedep333 Aug 20, 2020 • edited

Choose a reason for hiding this comment

mikedep333 Sep 8, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fao89 commented Aug 10, 2020

Choose a reason for hiding this comment

mikedep333 commented Sep 29, 2021

mdellweg commented Sep 29, 2021

mdellweg commented Oct 21, 2021

mdellweg commented Jan 21, 2022

mikedep333 left a comment

Choose a reason for hiding this comment

mikedep333 Aug 17, 2020 •

edited

mikedep333 Aug 20, 2020 •

edited

mikedep333 Sep 8, 2020 •

edited