Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding CentOS 7 to test matrix #395

Merged
merged 1 commit into from Aug 20, 2020
Merged

Adding CentOS 7 to test matrix #395

merged 1 commit into from Aug 20, 2020

Conversation

fao89
Copy link
Member

@fao89 fao89 commented Aug 18, 2020

[noissue]

@pulpbot
Copy link
Member

pulpbot commented Aug 18, 2020

WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue.

@fao89 fao89 requested a review from a team August 19, 2020 19:42
mikedep333
mikedep333 approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@mikedep333 mikedep333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mikedep333
Copy link
Member

mikedep333 commented Aug 20, 2020 •
edited

@fao89 Can you check if any of the tests are taking significantly longer now?

I am worried that GHA might be exhausting its 7GB of RAM when we have 4 containers running.

I was thinking of installing sar/sysstat and outputting at the end whether we have that issue.

Or in verify.yml, running free -m, and showing the registered variable's stdout_lines. It wouldn't show the highest usage during the ansible run, but it would show us the RAM usage when it is overall high (services are running, and ansible is running).

EDIT: I decided to do this myself, since I spent the time researching how:
#401

mikedep333 added a commit to mikedep333/pulp_installer that referenced this pull request Aug 20, 2020
@mikedep333
Show RAM usage in molecule verify phase.
7e99b67 
So we know if the CI env running 4 containers (w / Pulp running) +
4 ansible processes is low on RAM.

PR is based on pulp#395

[noissue]
@mikedep333 mikedep333 mentioned this pull request Aug 20, 2020
Merged
mikedep333 added a commit to mikedep333/pulp_installer that referenced this pull request Aug 20, 2020
@mikedep333
Show RAM usage in molecule verify phase.
d2a4832 
So we know if the CI env running 4 containers (w / Pulp running) +
4 ansible processes is low on RAM.

PR is based on pulp#395

[noissue]
@mikedep333 mikedep333 merged commit a91d164 into pulp:master Aug 20, 2020
mikedep333 added a commit to mikedep333/pulp_installer that referenced this pull request Aug 20, 2020
@mikedep333
Show RAM usage in molecule verify phase.
48f3573 
So we know if the CI env running 4 containers (w / Pulp running) +
4 ansible processes is low on RAM.

PR is based on pulp#395

[noissue]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikedep333 mikedep333 mikedep333 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fao89 @pulpbot @mikedep333